| Summary: | media-sound/hydrogen-1.2.2-r1 - /.../FileDialog.cpp: error: selectedFiles was not declared in this scope | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Professional Audio Applications Maintainers <proaudio> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ago, cbirchinger, colin.mcewan, gentoo, kripton, stefantalpalaru, ted, xavier.miller |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
emerge-info.txt
emerge-history.txt environment etc.clang.tar.xz etc.portage.tar.xz media-sound:hydrogen-1.2.2-r1:20240113-101858.log qlist-info.txt temp.tar.xz Add #include <QFileDialog> to FileDialog.h to fix the build failure |
||
Created attachment 882171 [details]
emerge-info.txt
Created attachment 882172 [details]
emerge-history.txt
Created attachment 882173 [details]
environment
Created attachment 882174 [details]
etc.clang.tar.xz
Created attachment 882175 [details]
etc.portage.tar.xz
Created attachment 882176 [details]
media-sound:hydrogen-1.2.2-r1:20240113-101858.log
Created attachment 882177 [details]
qlist-info.txt
Created attachment 882178 [details]
temp.tar.xz
*** Bug 923006 has been marked as a duplicate of this bug. *** Created attachment 884431 [details, diff]
Add #include <QFileDialog> to FileDialog.h to fix the build failure
This fixes this build issue for me.
Fixed on upstream Hydrogen's master branch, pending next release. This was masked in the Hydrogen CI system because precompiled headers are used in the Hydrogen build system to speed up the build. However, this is only possible when CMake supports it, which means cmake version 3.16 or greater. So, if this issue is actually being encountered, either 1. the Gentoo package has modified CMakeLists.txt file that disable precompiled header usage, or 2. the cmake in use is older than 3.16. I'd guess that it's 2. So upgrading the local cmake to the head version will probably also fix the issue. A working hydrogen-1.2.3 ebuild is available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay (In reply to Colin McEwan from comment #11) > Fixed on upstream Hydrogen's master branch, pending next release. > > This was masked in the Hydrogen CI system because precompiled headers are > used in the Hydrogen build system to speed up the build. However, this is > only possible when CMake supports it, which means cmake version 3.16 or > greater. > > So, if this issue is actually being encountered, either > 1. the Gentoo package has modified CMakeLists.txt file that disable > precompiled header usage, or > 2. the cmake in use is older than 3.16. > > I'd guess that it's 2. So upgrading the local cmake to the head version will > probably also fix the issue. No, it's 1. We disabled it in the eclass. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc2e39ec03509d1eea8aa101c7446df215bf5872 commit fc2e39ec03509d1eea8aa101c7446df215bf5872 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-04-01 06:45:39 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-04-01 06:45:53 +0000 media-sound/hydrogen: fix build w/o PCH We recently disabled PCH in cmake.eclass (3867345f8c2d9f24157508bc6372f479a82cf33f) which had some fallout. Add a missing include which this exposes. Thanks to Christian for giving the patch on the bug. Closes: https://bugs.gentoo.org/922034 Signed-off-by: Sam James <sam@gentoo.org> .../hydrogen/files/hydrogen-1.2.2-no-pch-include.patch | 11 +++++++++++ media-sound/hydrogen/hydrogen-1.2.2-r1.ebuild | 1 + 2 files changed, 12 insertions(+) |
| ^ /var/tmp/portage/media-sound/hydrogen-1.2.2-r1/work/hydrogen-1.2.2/src/gui/src/Widgets/FileDialog.cpp: In constructor FileDialog::FileDialog(QWidget*): /var/tmp/portage/media-sound/hydrogen-1.2.2-r1/work/hydrogen-1.2.2/src/gui/src/Widgets/FileDialog.cpp:30:4: error: type QFileDialog is not a direct base of FileDialog 30 | : QFileDialog( pParent ) { | ^~~~~~~~~~~ /var/tmp/portage/media-sound/hydrogen-1.2.2-r1/work/hydrogen-1.2.2/src/gui/src/Widgets/FileDialog.cpp: In member function void FileDialog::accept(): /var/tmp/portage/media-sound/hydrogen-1.2.2-r1/work/hydrogen-1.2.2/src/gui/src/Widgets/FileDialog.cpp:39:29: error: selectedFiles was not declared in this scope 39 | QFileInfo fileInfo( selectedFiles().first() ); | ^~~~~~~~~~~~~ ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop_plasma-20240111-173004 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-10 [2] x86_64-pc-linux-gnu-13 * clang/llvm (if any): clang version 17.0.6 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/17/bin Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg /usr/lib/llvm/17 17.0.6 Python 3.11.7 Available Ruby profiles: [1] ruby31 (with Rubygems) * Available Rust versions: [1] rust-bin-1.74.1 * The following VMs are available for generation-2: 1) Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17] 2) Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21] *) Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8] Available Java Virtual Machines: [1] openjdk-bin-8 system-vm [2] openjdk-bin-17 [3] openjdk-bin-21 The Glorious Glasgow Haskell Compilation System, version 9.2.8 php cli (if any): go version go1.21.6 linux/amd64 HEAD of ::gentoo commit ed0df297de9eff735159c5afe5e2493097d03a33 Author: Repository mirror & CI <repomirrorci@gentoo.org> Date: Sat Jan 13 08:48:11 2024 +0000 2024-01-13 08:48:10 UTC emerge -qpvO media-sound/hydrogen [ebuild N ] media-sound/hydrogen-1.2.2-r1 USE="alsa archive -doc -jack -ladspa -lash -osc -oss -portaudio -portmidi -pulseaudio"