Bug 921976

Summary:	dev-python/pip-23.3.2 fails test tests/unit/test_utils.py::test_rmtree_retries_for_3sec
Product:	Gentoo Linux	Reporter:	Jonathan Lovelace <kingjon3377>
Component:	Current packages	Assignee:	Python Gentoo Team <python>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mgorny
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	dev-python:pip-23.3.2:20240113-032301.log emerge-info.txt

Description Jonathan Lovelace 2024-01-13 04:01:30 UTC

Created attachment 882150 [details]
dev-python:pip-23.3.2:20240113-032301.log

dev-python/pip-23.3.2 fails its test phase. Specifically, the test tests/unit/test_utils.py::test_rmtree_retries_for_3sec errors out:

______________________________________________ ERROR at teardown of test_rmtree_retries_for_3sec _______________________________________________
[gw0] linux -- Python 3.11.7 /var/tmp/portage/dev-python/pip-23.3.2/work/pip-23.3.2-python3_11/install/usr/bin/python3.11

self = <tests.unit.test_utils.Failer object at 0x7f4e0f86bcd0>
args = (PosixPath('/var/tmp/portage/dev-python/pip-23.3.2/temp/pytest-of-portage/pytest-0/popen-gw0/test_rmtree_retries_for_3sec0'),)
kw = {'ignore_errors': True}

    def call(self, *args: Any, **kw: Any) -> None:
        """Fail with OSError self.max_fails times"""
        if time.time() < self.succeed_after:
>           raise OSError("Failed")
E           OSError: Failed

args       = (PosixPath('/var/tmp/portage/dev-python/pip-23.3.2/temp/pytest-of-portage/pytest-0/popen-gw0/test_rmtree_retries_for_3sec0'),)
kw         = {'ignore_errors': True}
self       = <tests.unit.test_utils.Failer object at 0x7f4e0f86bcd0>

tests/unit/test_utils.py:288: OSError

(I tried using sed in /etc/portage/env to tweak the timeout value used for this test; if it's higher than 3 seconds (it's 5 in the unmodified source code), this error happens (every time in my testing, which I admit has been only through Portage), while if it's lower than 3 seconds the test fails, rather than erroring out.)

Comment 1 Jonathan Lovelace 2024-01-13 04:03:10 UTC

Created attachment 882151 [details]
emerge-info.txt

Comment 2 Michał Górny archtester

2024-01-17 16:14:14 UTC

There are some setuptools-69.0.3 fixes in git, so I'll try if these help.

Comment 3 Larry the Git Cow gentoo-dev

2024-01-17 17:11:46 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d06eee3cabb37a3be6d52c74e30dbf0cf30c980

commit 6d06eee3cabb37a3be6d52c74e30dbf0cf30c980
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-01-17 16:19:04 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-01-17 17:11:43 +0000

    dev-python/pip: Backport fixes for >=setuptools-69.0.3
    
    Closes: https://bugs.gentoo.org/921976
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../pip/files/pip-23.3.2-setuptools-69.0.3.patch   | 383 +++++++++++++++++++++
 .../{pip-23.3.2.ebuild => pip-23.3.2-r1.ebuild}    |   1 +
 2 files changed, 384 insertions(+)