Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 921935

Summary: kde-apps/kate-addons-23.08.4: addons/project/kateproject.h:10:34: error: missing binary operator before token "("
Product: Gentoo Linux Reporter: Andreas Sturmlechner <asturm>
Component: Current packagesAssignee: Gentoo KDE team <kde>
Status: RESOLVED FIXED    
Severity: normal CC: confabulate, cyberbat83, sam
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://invent.kde.org/utilities/kate/-/issues/116
See Also: https://bugs.gentoo.org/show_bug.cgi?id=921720
https://bugs.gentoo.org/show_bug.cgi?id=920845
https://invent.kde.org/utilities/kate/-/merge_requests/1388
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log
kateproject.h.patch
The patch fixing rest missing includes

Description Andreas Sturmlechner gentoo-dev 2024-01-12 14:04:00 UTC 
Created attachment 882101 [details]
build.log

Portage 3.0.61 (python 3.11.7-final-0, default/linux/amd64/17.1/desktop/plasma, gcc-13, glibc-2.38-r9, 5.15.138-gentoo x86_64)
=================================================================
System uname: Linux-5.15.138-gentoo-x86_64-Intel-R-_Core-TM-_m7-6Y75_CPU_@_1.20GHz-with-glibc2.38
KiB Mem:     7534436 total,    319092 free
KiB Swap:    8015868 total,   5278204 free
Timestamp of repository gentoo: Fri, 12 Jan 2024 13:00:01 +0000
Head commit of repository gentoo: 6fa4d38fbaea475caf74e1bc611062e9d6c3475d
sh bash 5.2_p21-r2
ld GNU ld (Gentoo 2.41 p4) 2.41.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p21-r2::gentoo
dev-java/java-config:      2.3.3-r1::gentoo
dev-lang/perl:             5.38.2-r1::gentoo
dev-lang/python:           3.11.7::gentoo, 3.12.1_p1::gentoo
dev-lang/rust-bin:         1.72.0::gentoo
dev-util/cmake:            3.28.1-r1::gentoo
dev-util/meson:            1.3.1::gentoo
sys-apps/baselayout:       2.14-r1::gentoo
sys-apps/openrc:           0.52.1::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-devel/autoconf:        2.13-r8::gentoo, 2.71-r7::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.41-r4::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           15.0.7-r3::gentoo, 17.0.6::gentoo
sys-devel/gcc:             13.2.1_p20231216::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             15.0.7::gentoo
sys-devel/llvm:            15.0.7-r3::gentoo, 17.0.6::gentoo
sys-devel/make:            4.4.1-r1::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r9::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: False
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 

kde
    location: /srv/kde
    masters: gentoo
    volatile: True

qt
    location: /srv/qt
    masters: gentoo
    volatile: True

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE AdobeFlash-11.x android AVASYS Eizo Interbase-1.0 PUEL unRAR OSGi-Specification-2.0 Q3AEULA Q3AEULA-20000111 worldofpadman intel-ucode linux-fw-redistributable no-source-code as-is bh-luxi exljbris-free free-noncomm freedist MSttfEULA all-rights-reserved EPSON-2018 RAR"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=native -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=native -pipe"
DISTDIR="/var/lib/portage/distfiles"
EMERGE_DEFAULT_OPTS=" --usepkg-exclude 'kde-plasma/plasma-workspace-wallpapers sys-kernel/gentoo-sources virtual/*' --keep-going"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -march=native -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles getbinpkg ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=native -pipe"
GENTOO_MIRRORS="http://gentoo.lagis.at/ ftp://tux.rainside.sk/gentoo/ http://tux.rainside.sk/gentoo/ ftp://gentoo.lagis.at/ http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/"
LANG="de_AT.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
LINGUAS="en_GB en de_AT de"
MAKEOPTS="-j2"
PKGDIR="/var/lib/portage/packages"
PORTAGE_BINHOST="http://192.168.1.27/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 aacs acl acpi activities addressbook alsa amd64 apache2 avahi avif bash-completion bluetooth bluray branding bzip2 cairo caps cdda cddb cdparanoia cdr cli colord corefonts crypt cups custom-cflags custom-cpuopts dbus declarative dirac discover djvu dri dts dvb dvd dvdr egl elogind encode eps epub exif expat ffmpeg fftw flac fontconfig fortran ftp gd gdbm geolocation gif git glamor gpg gpm gs gui heif iconv icu id3tag idn imagemagick inotify jpeg jpeg2k jumbo-build kde kwallet lame laptop lastfm lcms libinput libnotify libtirpc lm-sensors lqr lzma lzo mad markdown matroska mng mp3 mp4 mpeg mplayer mtp multilib musicbrainz ncurses networkmanager nls offensive ogg openexr opengl openmp pam pcre pdf pipewire plasma pm-utils png policykit postgres ppds pulseaudio qml qrcode qt5 quicktime raw readline samba schroedinger screencast sdl seccomp secure-delete semantic-desktop share smp sound spell split-usr ssl startup-notification svg syslog taglib telemetry test-rust theora thunderbolt tidy tiff touchpad truetype udev udisks uefi unicode upower usb v4l vaapi vcd vlc vorbis vpx vulkan wayland webengine webp widgets x264 xattr xcb xcomposite xft xml xmp xpm xv xvid yaz zeroconf zip zlib" ABI_X86="64" ADA_TARGET="gnat_2021" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="canon nikon pentax ptp2 ricoh" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en_GB en de_AT de" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres9_4 postgres12" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="i386 x86_64" RUBY_TARGETS="ruby26" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS



> In file included from addons/project/kateprojectworker.h:10,
>                  from addons/project/kateprojectworker.cpp:8:
> addons/project/kateproject.h:10:5: warning: "QT_VERSION" is not defined, evaluates to 0 [-Wundef]
>    10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
>       |     ^~~~~~~~~~
> addons/project/kateproject.h:10:18: warning: "QT_VERSION_CHECK" is not defined, evaluates to 0 [-Wundef]
>    10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
>       |                  ^~~~~~~~~~~~~~~~
> addons/project/kateproject.h:10:34: error: missing binary operator before token "("
>    10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
>       |                                  ^
> addons/project/kateproject.h:279:92: error: ‘KTextEditor::ModificationInterface’ has not been declared
>   279 |     void slotModifiedOnDisk(KTextEditor::Document *document, bool isModified, KTextEditor::ModificationInterface::ModifiedOnDiskReason reason);
>       |                                                                                            ^~~~~~~~~~~~~~~~~~~~~
> addons/project/kateproject.h:279:136: error: expected ‘,’ or ‘...’ before ‘reason’
>   279 |     void slotModifiedOnDisk(KTextEditor::Document *document, bool isModified, KTextEditor::ModificationInterface::ModifiedOnDiskReason reason);
>       |                                                                                                                                        ^~~~~~
>
Comment 1 MickKi 2024-01-12 14:10:15 UTC 
Same failure on an amd64 here, with warnings about:

"QT_VERSION" is not defined, evaluates to 0 on:

kateprojectitem.cpp.o
kateproject.cpp.o
kateprojectview.cpp.o
kateprojectworker.cpp.o

before it bails out.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-12 14:30:04 UTC 
Looking.
Comment 3 cyberbat 2024-01-12 15:55:26 UTC 
Seems that 

#include <QtGlobal>

is needed before the IF

https://stackoverflow.com/questions/24899558/how-to-check-qt-version-to-include-different-header
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-12 16:08:23 UTC 
Created attachment 882107 [details, diff]
kateproject.h.patch

Try this? asturm said he may have hit another issue after it, so if this doesn't work for you, please give me the new build.log.
Comment 5 cyberbat 2024-01-12 16:13:20 UTC 
Created attachment 882108 [details, diff]
The patch fixing rest missing includes

I have fixed all issues with missing includes with this patch
Comment 6 cyberbat 2024-01-12 16:18:22 UTC 
And the same for kde-apps/kate
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-12 16:27:03 UTC 
(In reply to cyberbat from comment #5)
> Created attachment 882108 [details, diff] [details, diff]
> The patch fixing rest missing includes
> 
> I have fixed all issues with missing includes with this patch

Thank you! I'll send it upstream and apply to the whole Kate suite.
Comment 8 Larry the Git Cow gentoo-dev 2024-01-12 16:59:11 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fcc58d11dfd83610f3f3df8e98e7f9ebf593b830

commit fcc58d11dfd83610f3f3df8e98e7f9ebf593b830
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 16:58:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 16:58:59 +0000

    kde-apps/kate-lib: further no-pch fixes
    
    Closes: https://bugs.gentoo.org/921935
    Bug: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kate-lib/files/kate-23.08.4-no-pch.patch | 56 ++++++++++++++++++-----
 1 file changed, 44 insertions(+), 12 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3ff857b56efb6bb7c011432f5e41544471b5591

commit c3ff857b56efb6bb7c011432f5e41544471b5591
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 16:58:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 16:58:39 +0000

    kde-apps/kwrite: further no-pch fixes
    
    Closes: https://bugs.gentoo.org/921935
    Bug: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kwrite/files/kate-23.08.4-no-pch.patch | 56 +++++++++++++++++++------
 1 file changed, 44 insertions(+), 12 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ebfa971a8b829712595c108ab9f3523cead261ca

commit ebfa971a8b829712595c108ab9f3523cead261ca
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 16:58:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 16:58:21 +0000

    kde-apps/kate-addons: further no-pch fixes
    
    Closes: https://bugs.gentoo.org/921935
    Bug: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 .../kate-addons/files/kate-23.08.4-no-pch.patch    | 56 +++++++++++++++++-----
 1 file changed, 44 insertions(+), 12 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fefe28433c4c61ce7f13aaf3fa4aab292e49d4cb

commit fefe28433c4c61ce7f13aaf3fa4aab292e49d4cb
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 16:57:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 16:57:32 +0000

    kde-apps/kate: further no-pch fixes
    
    Closes: https://bugs.gentoo.org/921935
    Bug: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kate/files/kate-23.08.4-no-pch.patch | 56 +++++++++++++++++++++------
 1 file changed, 44 insertions(+), 12 deletions(-)