Bug 921731

Summary:	media-sound/audacity-3.3.3: "AboutDialog.cpp:570:10: error: ‘LINSTALL_PREFIX’ was not declared in this scope; did you mean ‘wxINSTALL_PREFIX’?"
Product:	Gentoo Linux	Reporter:	Alexis <flexibeast>
Component:	Current packages	Assignee:	Professional Audio Applications Maintainers <proaudio>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dark.knight.ita, leohdz172, richard
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=920845
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Output of `emerge --info` Build log

Description Alexis 2024-01-11 00:30:12 UTC

Originally reported by leyvi at https://forums.gentoo.org/viewtopic-t-1166878.html.

media-sound/audacity-3.3.3 currently fails to build:

```
FAILED: src/CMakeFiles/Audacity.dir/AboutDialog.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DAUDACITY_DLL_API="" -DAUDIO_DEVICES_API="" -DAUDIO_GRAPH_API="" -DAUDIO_IO_API="" -DAudacity_EXPORTS -DBASIC_UI_API="" -DBUILDING_AUDACITY -DCMAKE -DCOMMAND_PARAMETERS_API="" -DCOMPONENTS_API="" -DEFFECTS_API="" -DEXCEPTIONS_API="" -DEXPERIMENTAL_CRASH_REPORT -DEXPERIMENTAL_DRAGGABLE_PLAY_HEAD -DEXPERIMENTAL_FULL_WASAPI -DEXPERIMENTAL_HALF_WAVE -DEXPERIMENTAL_KEY_VIEW -DEXPERIMENTAL_MIDI_OUT -DEXPERIMENTAL_MODULE_PREFS -DEXPERIMENTAL_NOISE_REDUCTION -DEXPERIMENTAL_NOTETRACK_OVERLAY -DEXPERIMENTAL_NYQUIST_SPLIT_CONTROL -DEXPERIMENTAL_PUNCH_AND_ROLL -DEXPERIMENTAL_SCIENCE_FILTERS -DEXPERIMENTAL_SCROLLING_LIMITS -DEXPERIMENTAL_SCRUBBING_SCROLL_WHEEL -DEXPERIMENTAL_SCRUBBING_SUPPORT -DEXPERIMENTAL_SPECTRAL_EDITING -DEXPERIMENTAL_THEMING -DEXPERIMENTAL_TWO_TONE_TIME_RULER -DEXPERIMENTAL_ZOOM_TOGGLE_BUTTON -DFFMPEG_SUPPORT_API="" -DFILES_API="" -DGRAPHICS_API="" -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK -DIPC_API="" -DMATH_API="" -DMODULE_MANAGER_API="" -DNUMERIC_FORMATS_API="" -DPREFERENCES_API="" -DPROJECT_API="" -DPROJECT_FILE_IO_API="" -DPROJECT_HISTORY_API="" -DPROJECT_RATE_API="" -DREALTIME_EFFECTS_API="" -DREGISTRIES_API="" -DSAMPLE_TRACK_API="" -DSCREEN_GEOMETRY_API="" -DSHUTTLEGUI_API="" -DSNAPPING_API="" -DSTRINGS_API="" -DSTRING_UTILS_API="" -DTAGS_API="" -DTHEME_API="" -DTHEME_RESOURCES_API="" -DTIME_FREQUENCY_SELECTION_API="" -DTIME_TRACK_API="" -DTRACK_API="" -DTRACK_SELECTION_API="" -DTRANSACTIONS_API="" -DUSE_FFMPEG -DUSE_NYQUIST=1 -DUSE_PORTMIXER=1 -DUTILITY_API="" -DWAVE_TRACK_API="" -DWXUSINGDLL -DWX_INIT_API="" -DWX_WRAPPERS_API="" -DXML_API="" -D_FILE_OFFSET_BITS=64 -D__WXGTK__ -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3_build/src/private -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/include -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/src -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-theme-resources -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-theme -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-files -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-exceptions -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-utility -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-basic-ui -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-strings -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-preferences -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-components -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-graphics -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-tags -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-project-history -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-project -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-registries -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-xml -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-string-utils -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-transactions  -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-project-file-io -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-wave-track -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-project-rate -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-audio-devices -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/lib-src/portmixer/include -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-math -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-sample-track -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-audio-graph -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-track -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-track-selection -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-time-frequency-selection -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-screen-geometry -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-sentry-reporting -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-effects -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-audio-io -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-realtime-effects -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-module-manager -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-ipc -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-command-parameters -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-numeric-formats -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-wx-init -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-shuttlegui -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-wx-wrappers -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-time-track -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-snapping -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-ffmpeg-support -I/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/lib-src/libnyquist -isystem /usr/lib64/wx/include/gtk3-unicode-3.2-gtk3 -isystem /usr/include/wx-3.2-gtk3 -isystem /usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/lib64/libffi/include -isystem /usr/include/harfbuzz -isystem /usr/include/freetype2 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/fribidi -isystem /usr/include/cairo -isystem /usr/include/libpng16 -isystem /usr/include/pixman-1 -isystem /usr/include/gdk-pixbuf-2.0 -isystem /usr/include/webp -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/atk-1.0 -isystem /usr/include/at-spi2-atk/2.0 -isystem /usr/include/at-spi-2.0 -isystem /usr/include/dbus-1.0 -isystem /usr/lib64/dbus-1.0/include -isystem /usr/include/lilv-0 -isystem /usr/include/serd-0 -isystem /usr/include/sord-0 -isystem /usr/include/zix-0 -isystem /usr/include/sratom-0 -isystem /usr/include/suil-0 -isystem /usr/include/soundtouch  -DNDEBUG -march=native -O2 -pipe -fdiagnostics-color=always -std=gnu++17 -DAUDACITY_VERSION=3 -DAUDACITY_RELEASE=3 -DAUDACITY_REVISION=3 -DAUDACITY_MODLEVEL=0 -DAUDACITY_VERSION_STRING=L\"3.3.3\" -DAUDACITY_FILE_VERSION=L\"3,3,3,0\" -DPROHIBITED==delete -Dsafenew=new -DWXINTL_NO_GETTEXT_MACRO -U_DEBUG -DIS_RELEASE -pthread -MD -MT src/CMakeFiles/Audacity.dir/AboutDialog.cpp.o -MF src/CMakeFiles/Audacity.dir/AboutDialog.cpp.o.d -o src/CMakeFiles/Audacity.dir/AboutDialog.cpp.o -c /var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/src/AboutDialog.cpp
In file included from /usr/include/wx-3.2-gtk3/wx/version.h:16,
                 from /usr/include/wx-3.2-gtk3/wx/defs.h:189,
                 from /usr/include/wx-3.2-gtk3/wx/event.h:14,
                 from /usr/include/wx-3.2-gtk3/wx/window.h:18,
                 from /usr/include/wx-3.2-gtk3/wx/panel.h:19,
                 from /var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/libraries/lib-wx-wrappers/wxPanelWrapper.h:12,
                 from /var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/src/AboutDialog.h:15,
                 from /var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/src/AboutDialog.cpp:29:
/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/src/AboutDialog.cpp: In member function ‘void AboutDialog::PopulateInformationPage(ShuttleGui&)’:
/var/tmp/portage/media-sound/audacity-3.3.3/work/audacity-Audacity-3.3.3/src/AboutDialog.cpp:570:10: error: ‘LINSTALL_PREFIX’ was not declared in this scope; did you mean ‘wxINSTALL_PREFIX’?
  570 |          wxT(INSTALL_PREFIX));
      |          ^~~
```

My last successful build of Audacity was on 2023-12-16.

Attachment with output of `emerge --info` to follow shortly.

Reproducible: Always

Comment 1 Alexis 2024-01-11 00:31:01 UTC

Created attachment 881884 [details]
Output of `emerge --info`

Comment 2 Leonardo Hernández Hernández 2024-01-11 04:22:29 UTC

Please always attach the full build.log (compressed if necessary).

Comment 3 Alexis 2024-01-11 04:34:54 UTC

Created attachment 881885 [details]
Build log

Comment 4 Alexis 2024-01-11 04:35:25 UTC

(In reply to Leonardo Hernández Hernández from comment #2)
> Please always attach the full build.log (compressed if necessary).

My apologies. bzip2'd build log now attached.

Comment 5 Sam James archtester

2024-01-11 12:12:37 UTC

My guess is the PCH change.

Comment 6 Larry the Git Cow gentoo-dev

2024-01-11 13:01:29 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=986e00639a6bd9ca0d650743941a1d7e6b903821

commit 986e00639a6bd9ca0d650743941a1d7e6b903821
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-11 12:57:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-11 13:00:27 +0000

    media-sound/audacity: disable PCH harder
    
    The build system handles its "config.h" header in an unusual way, where it
    passes -include via CMake as long as PCH is disabled. But it only checks
    its own build system option, not the standard CMake option to force off PCH,
    so we started getting build failures w/ the recent cmake.eclass change to pass
    the latter.
    
    Closes: https://bugs.gentoo.org/921731
    Signed-off-by: Sam James <sam@gentoo.org>

 media-sound/audacity/audacity-3.3.3.ebuild | 4 ++--
 media-sound/audacity/audacity-9999.ebuild  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comment 7 Larry the Git Cow gentoo-dev

2024-01-11 13:03:27 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb004b1b81732a8e0830e7d62ebe835a39ee36b9

commit fb004b1b81732a8e0830e7d62ebe835a39ee36b9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-11 13:02:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-11 13:02:35 +0000

    media-sound/audacity: backport PCH fix
    
    Backport 986e00639a6bd9ca0d650743941a1d7e6b903821.
    
    Bug: https://bugs.gentoo.org/921731
    Signed-off-by: Sam James <sam@gentoo.org>

 media-sound/audacity/audacity-2.4.2-r3.ebuild | 4 ++--
 media-sound/audacity/audacity-3.2.5-r1.ebuild | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)