Bug 921707

Summary:	media-libs/libmodplug-0.8.9.1: fails to build (lto): src/load_abc.cpp:421:3: error: type 'struct MMFILE' violates the C++ One Definition Rule [-Werror=odr]
Product:	Gentoo Linux	Reporter:	Rafael Kitover <rkitover>
Component:	Current packages	Assignee:	Gentoo Sound Team <sound>
Status:	RESOLVED FIXED
Severity:	normal	CC:	leohdz172
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550
Attachments:	build log emerge --info

Description Rafael Kitover 2024-01-10 13:48:51 UTC

Fails to build with recommended LTO flags according to:

https://wiki.gentoo.org/wiki/LTO

> emerge -pqv =media-libs/libmodplug-0.8.9.1
[ebuild  N    ] media-libs/libmodplug-0.8.9.1  ABI_X86="-32 (64) (-x32)"

Reproducible: Always

Comment 1 Rafael Kitover 2024-01-10 13:49:20 UTC

Created attachment 881817 [details]
build log

Comment 2 Rafael Kitover 2024-01-10 13:49:34 UTC

Created attachment 881818 [details]
emerge --info

Comment 3 Larry the Git Cow gentoo-dev

2024-03-14 06:06:17 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99d9c29cd536fb1be71e277fd5a69b7dac3e1936

commit 99d9c29cd536fb1be71e277fd5a69b7dac3e1936
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-14 05:10:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-14 06:05:31 +0000

    media-libs/libmodplug: mark as LTO-unsafe
    
    There are 3 different upstreams described for this package. One
    homepage, another SRC_URI, and a third in metadata.xml. Nowhere is this
    actually maintained, however.
    
    Closes: https://bugs.gentoo.org/921707
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/libmodplug/libmodplug-0.8.9.1.ebuild | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)