Bug 921438

Summary:	media-libs/libaom: compile as Release
Product:	Gentoo Linux	Reporter:	Duane Robertson <duane>
Component:	Current packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=914614
Whiteboard:
Package list:		Runtime testing required:	---

Description Duane Robertson 2024-01-06 07:47:29 UTC

media-libs/libaom has a lot of arguably trivial assertions that are left active in the current ebuilds. The project recommends compiling as release for any real use. I've added the following to my copy of the ebuilds:

  -DCMAKE_BUILD_TYPE=Release
  -DAOM_EXTRA_C_FLAGS=-DNDEBUG
  -DAOM_EXTRA_CXX_FLAGS=-DNDEBUG

It might be a good idea to at least set the build type for the benefit of people who want to actually use the software, not debug it. Otherwise you get errors like this when the codec is perfectly capable of producing valid video:

ffmpeg: /var/tmp/portage/media-libs/libaom-3.7.0-r2/work/libaom-3.7.0/av1/encoder/pass2_strategy.c:4088: av1_twopass_postencode_update: Assertion `cpi->twopass_frame.stats_in > twopass->stats_buf_ctx->stats_in_start' failed.

Comment 1 Sam James archtester

2024-01-06 07:49:02 UTC

Ah, not this again. Will do.

Comment 2 Larry the Git Cow gentoo-dev

2024-02-02 00:08:10 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d3e8e731cc4f8c341762c5d15569ae19cf4d471

commit 6d3e8e731cc4f8c341762c5d15569ae19cf4d471
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-02-02 00:06:53 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-02-02 00:06:53 +0000

    media-libs/libaom: build without asserts by default
    
    Both to follow upstream recommendations (see bug #921438 -- I did also have a better
    source for this than the README but I can't find it now, or maybe it's changed
    in the meantime), but also to avoid asserts firing during daily use which don't
    seem to be bothering anybody upstream (bug #914614). Not ideal but it's been reported
    already and went nowhere.
    
    Closes: https://bugs.gentoo.org/914614
    Closes: https://bugs.gentoo.org/921438
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/libaom/libaom-3.8.0-r1.ebuild | 148 +++++++++++++++++++++++++++++++
 1 file changed, 148 insertions(+)