Bug 921257

Summary:	net-p2p/mldonkey-3.1.7-r4 fails to compile (GCC-14-SYSTEM): charsetstubs.c:1207:23: error: passing argument 2 of iconv from incompatible pointer type [-Wincompatible-pointer-types]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Jesús P Rey (Chuso) <gentoo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	eschwartz, phantom4, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/ygrek/mldonkey/pull/92 https://github.com/gentoo/gentoo/pull/38838
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-01-03 08:58:40 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-p2p/mldonkey-3.1.7-r4 fails to compile (GCC-14-SYSTEM).
Discovered on: amd64 (internal ref: gcc14_tinderbox)

NOTE:
(GCC-14-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-14 but this bug MAY or MAY NOT BE related to the new compiler

Comment 1 Agostino Sarubbo gentoo-dev

2024-01-03 08:58:42 UTC

Created attachment 881358 [details]
build.log

build log and emerge --info

Comment 2 Jesús P Rey (Chuso) 2024-01-10 11:17:18 UTC

I am able to reproduce it. I will check what fixing it would involve and will report it upstream.

Comment 3 Jesús P Rey (Chuso) 2024-01-10 14:58:31 UTC

Reported upstream with a proposed fix: https://github.com/ygrek/mldonkey/pull/92

Comment 4 Per Pomsel 2024-07-18 07:30:13 UTC

I can confirm that the proposed fix from https://github.com/ygrek/mldonkey/pull/92 works for me.

Comment 5 Eli Schwartz gentoo-dev

2024-09-19 14:08:22 UTC

The patch in question was merged in version 3.2.0 / 3.2.1, can you try updating the package?

Comment 6 Larry the Git Cow gentoo-dev

2024-10-01 23:13:21 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f1821977ea27d5d23a6e32f78ffbcf1776527ca

commit 6f1821977ea27d5d23a6e32f78ffbcf1776527ca
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2024-09-30 21:04:07 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-10-01 23:04:11 +0000

    net-p2p/mldonkey: 3.2.1 version bump.
    
    Removed inactive and obsolete Sourceforge upstream.
    
    Closes: https://bugs.gentoo.org/749609
    Closes: https://bugs.gentoo.org/921257
    Signed-off-by: Jesus P Rey (Chuso) <gentoo@chuso.net>
    Closes: https://github.com/gentoo/gentoo/pull/38838
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 net-p2p/mldonkey/Manifest              |   1 +
 net-p2p/mldonkey/metadata.xml          |   1 -
 net-p2p/mldonkey/mldonkey-3.2.1.ebuild | 128 +++++++++++++++++++++++++++++++++
 3 files changed, 129 insertions(+), 1 deletion(-)