Bug 921166

Summary:	media-video/handbrake-1.6.1 fails to compile (GCC-14-SYSTEM): muxavformat.c:1209:18: error: implicit declaration of function time [-Wimplicit-function-declaration]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	CONFIRMED ---
Severity:	normal	CC:	jstein, kocelfc
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log backported patch

Description Agostino Sarubbo gentoo-dev

2024-01-01 14:40:44 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-video/handbrake-1.6.1 fails to compile (GCC-14-SYSTEM).
Discovered on: amd64 (internal ref: gcc14_tinderbox)

NOTE:
(GCC-14-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-14 but this bug MAY or MAY NOT BE related to the new compiler

Comment 1 Agostino Sarubbo gentoo-dev

2024-01-01 14:40:46 UTC

Created attachment 881216 [details]
build.log

build log and emerge --info

Comment 2 H. Peter Pfeufer 2024-01-06 22:38:28 UTC

Getting the same message during compile on GCC 13.

```
 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * ../libhb/muxavformat.c:1212:5: warning: incompatible implicit declaration of built-in function ‘strftime’ [-Wbuiltin-declaration-mismatch]
```


```
root@thor.walhalla.lan ~ $
» gcc-config -l
 [1] x86_64-pc-linux-gnu-13 *
```


Handbrake compiles and starts, but as soon as I want to start a transcode job it crashes with a segmentation fault.

```
ppfeufer@thor.walhalla.lan ~ $
» ghb

(fr.handbrake.ghb:17948): Gtk-WARNING **: 23:34:37.181: Locale not supported by C library.
        Using the fallback 'C' locale.
Segmentation fault (core dumped)
```

Comment 3 Kostadin Shishmanov 2024-01-10 14:02:29 UTC

Created attachment 881819 [details, diff]
backported patch

This is fixed upstream: https://github.com/HandBrake/HandBrake/commit/5fc06017f40eb152bad36cfa7436a8f50f4ed2ca