Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 920905

Summary: net-vpn/tor-0.4.7.16-r1 fails tests on arm: FAIL src/test/test_sandbox.c:264: opendir: Operation not permitted [1]
Product: Gentoo Linux Reporter: matoro <matoro_gentoo>
Component: Current packagesAssignee: John Helmert III <ajak>
Status: RESOLVED FIXED    
Severity: normal CC: matoro_gentoo, sam
Priority: Normal Keywords: TESTFAILURE
Version: unspecified   
Hardware: ARM   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=920063
https://gitlab.torproject.org/tpo/core/tor/-/issues/40912
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 916761, 922191    
Attachments: build.log and emerge --info

Description matoro archtester 2023-12-28 21:05:07 UTC
Patch from bug 920063 appears to be limited to arm64 but it needs to be extended to arm also

sandbox/opendir_dirname: [forking] 
  FAIL src/test/test_sandbox.c:264: opendir: Operation not permitted [1]
  [opendir_dirname FAILED]
sandbox/openat_filename: SKIPPED
sandbox/chmod_filename: [forking] 
         OK src/test/test_sandbox.c:188: assert(rc OP_EQ -1): -1 vs -1
         OK src/test/test_sandbox.c:189: assert(errsv OP_EQ EPERM): 1 vs 1
sandbox/chown_filename: [forking] 
  FAIL src/test/test_sandbox.c:202: chown: Operation not permitted [1]
  [chown_filename FAILED]
sandbox/rename_filename: [forking] 
         OK src/test/test_sandbox.c:226: assert(rc OP_EQ -1): -1 vs -1
         OK src/test/test_sandbox.c:227: assert(errsv OP_EQ EPERM): 1 vs 1

Reproducible: Always
Comment 1 matoro archtester 2023-12-28 21:08:46 UTC
build.log and emerge --info:

https://paste.matoro.tk/8lg12q4



These MAY come from running on an arm64 kernel
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-31 22:10:29 UTC
Could you rpeort this upstream please? (also forgot to CC other maint)
Comment 3 matoro archtester 2024-01-31 22:11:35 UTC
Created attachment 883878 [details]
build.log and emerge --info

Here's a log from 0.4.8.10 with a proper linux32 showing the issue is still present.
Comment 4 matoro archtester 2024-02-29 19:33:32 UTC
NixOS seems to have reported an extremely similar issue in https://gitlab.torproject.org/tpo/core/tor/-/issues/40912, I've gone ahead and commented on that rather than opening a new one since they are likely related at the very least.
Comment 5 Larry the Git Cow gentoo-dev 2024-04-15 07:42:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6e604b1d706779f2a93bf349380d4531c5eede5a

commit 6e604b1d706779f2a93bf349380d4531c5eede5a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-04-15 07:41:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-15 07:41:20 +0000

    net-vpn/tor: skip known-broken sandbox tests on arm32
    
    The seccomp support in Tor, just like seccomp in general, is known to
    be brittle and seccomp isn't enabled by default (bug #713690). It's therefore not a
    serious failure even if we'd like it to get fixed.
    
    Bug: https://bugs.gentoo.org/713690
    Closes: https://bugs.gentoo.org/920905
    Signed-off-by: Sam James <sam@gentoo.org>

 net-vpn/tor/tor-0.4.7.16-r1.ebuild | 13 ++++++++++++-
 net-vpn/tor/tor-0.4.8.10.ebuild    | 11 +++++++++++
 net-vpn/tor/tor-0.4.8.11.ebuild    | 11 +++++++++++
 net-vpn/tor/tor-9999.ebuild        | 13 ++++++++++++-
 4 files changed, 46 insertions(+), 2 deletions(-)
Comment 6 matoro archtester 2024-04-17 22:52:33 UTC
This is still missing one for arm.

sandbox/chown_filename: [forking] 
  FAIL src/test/test_sandbox.c:202: chown: Operation not permitted [1]
  [chown_filename FAILED]
Comment 7 Larry the Git Cow gentoo-dev 2024-04-17 23:04:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61668a070e2bcab90e5af9e99a3f7db7c8f13f3e

commit 61668a070e2bcab90e5af9e99a3f7db7c8f13f3e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-04-17 23:03:12 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-17 23:03:12 +0000

    net-vpn/tor: add another sandbox skip test for arm
    
    Bug: https://bugs.gentoo.org/920905
    Fixes: 6e604b1d706779f2a93bf349380d4531c5eede5a
    Signed-off-by: Sam James <sam@gentoo.org>

 net-vpn/tor/tor-0.4.7.16-r1.ebuild | 1 +
 net-vpn/tor/tor-0.4.8.10.ebuild    | 1 +
 net-vpn/tor/tor-0.4.8.11.ebuild    | 1 +
 net-vpn/tor/tor-9999.ebuild        | 1 +
 4 files changed, 4 insertions(+)