Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 920772

Summary: media-gfx/xloadimage-4.1-r16 - pdsuncomp.c: error: passing argument 3 of decompress from incompatible pointer type [-Wincompatible-pointer-types]
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal CC: nuitari, spreetec
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=896232
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 870412, 941869    
Attachments: emerge-info.txt
emerge-history.txt.xz
environment
etc.clang.tar.xz
etc.portage.tar.xz
logs.tar.xz
media-gfx:xloadimage-4.1-r16:20231227-003034.log
qlist-info.txt.xz
temp.tar.xz
Proposed patch for the incompatible pointer type error

Description Toralf Förster gentoo-dev 2023-12-27 08:53:55 UTC
too long lines were shrinked:

x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fno-diagnostics-color -DTIFFHeader=TIFFHeaderCommon -c -DHAVE_CONFIG_H -DSYSPATHFILE=\"/etc/X11/Xloadimage\" niff.c
x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fno-diagnostics-color -DTIFFHeader=TIFFHeaderCommon -c -DHAVE_CONFIG_H -DSYSPATHFILE=\"/etc/X11/Xloadimage\" options.c
x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fno-diagnostics-color -DTIFFHeader=TIFFHeaderCommon -c -DHAVE_CONFIG_H -DSYSPATHFILE=\"/etc/X11/Xloadimage\" pbm.c
x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fno-diagnostics-color -DTIFFHeader=TIFFHeaderCommon -c -DHAVE_CONFIG_H -DSYSPATHFILE=\"/etc/X11/Xloadimage\" pcx.c
x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fno-diagnostics-color -DTIFFHeader=TIFFHeaderCommon -c -DHAVE_CONFIG_H -DSYSPATHFILE=\"/etc/X11/Xloadimage\" pdsuncomp.c
pdsuncomp.c: In function pdsRead:
pdsuncomp.c:434:44: error: passing argument 3 of decompress from incompatible pointer type [-Wincompatible-pointer-types]
  434 |         out_length= decompress(ibuf, obuf, &in_length, &out_length);
      |                                            ^~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1-20231215-225005

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10
 [2] x86_64-pc-linux-gnu-14 *
clang/llvm (if any):
clang version 17.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/17/bin
Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg
/usr/lib/llvm/17
17.0.6
Python 3.11.7
Available Ruby profiles:
  (none found)
Available Rust versions:
  [1]   rust-bin-1.74.1 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 11.0.20.1_p1 [openjdk-bin-11]
2)	Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17]
*)	Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21]
4)	Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8 
  [2]   openjdk-bin-11 
  [3]   openjdk-bin-17 
  [4]   openjdk-bin-21  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.2.8
php cli (if any):
go version go1.21.5 linux/amd64

  HEAD of ::gentoo
commit 5f3c15298f49b985544a43eff393c5d17ff604b3
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Tue Dec 26 23:32:01 2023 +0000

    2023-12-26 23:32:00 UTC

emerge -qpvO media-gfx/xloadimage
[ebuild  N    ] media-gfx/xloadimage-4.1-r16  USE="png -jpeg -tiff"
Comment 1 Toralf Förster gentoo-dev 2023-12-27 08:53:56 UTC
Created attachment 880411 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-12-27 08:53:57 UTC
Created attachment 880412 [details]
emerge-history.txt.xz
Comment 3 Toralf Förster gentoo-dev 2023-12-27 08:53:58 UTC
Created attachment 880413 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2023-12-27 08:53:59 UTC
Created attachment 880414 [details]
etc.clang.tar.xz
Comment 5 Toralf Förster gentoo-dev 2023-12-27 08:54:00 UTC
Created attachment 880415 [details]
etc.portage.tar.xz
Comment 6 Toralf Förster gentoo-dev 2023-12-27 08:54:01 UTC
Created attachment 880416 [details]
logs.tar.xz
Comment 7 Toralf Förster gentoo-dev 2023-12-27 08:54:02 UTC
Created attachment 880417 [details]
media-gfx:xloadimage-4.1-r16:20231227-003034.log
Comment 8 Toralf Förster gentoo-dev 2023-12-27 08:54:03 UTC
Created attachment 880418 [details]
qlist-info.txt.xz
Comment 9 Toralf Förster gentoo-dev 2023-12-27 08:54:04 UTC
Created attachment 880419 [details]
temp.tar.xz
Comment 10 Markus Giese 2024-06-27 09:18:04 UTC
having the same issue. with gcc14 is does not compile, while with gcc13 it works

i can not figure out why it is pulled in on world update

equery depends -a media-gfx/xloadimage reports nothing
Comment 11 Nuitari 2024-09-16 02:28:41 UTC
Created attachment 903097 [details, diff]
Proposed patch for the incompatible pointer type error

Signed-off-by: Stephane Bakhos <nuitari@nuitari.net>
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-23 17:40:15 UTC
(In reply to Nuitari from comment #11)
> Created attachment 903097 [details, diff] [details, diff]
> Proposed patch for the incompatible pointer type error
> 
> Signed-off-by: Stephane Bakhos <nuitari@nuitari.net>

Looks good to me, thank you!
Comment 13 Larry the Git Cow gentoo-dev 2024-11-23 17:43:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5d24a109bf52c23c565f26d795efdeaf010978c

commit a5d24a109bf52c23c565f26d795efdeaf010978c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-11-23 17:42:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-11-23 17:43:28 +0000

    media-gfx/xloadimage: fix modern C issue
    
    * Fix sed delimiter for CFLAGS
    * Fix modern C issue (thanks Stephane Bakhos)
    
    Closes: https://bugs.gentoo.org/710428
    Closes: https://bugs.gentoo.org/920772
    Thanks-to: Stephane Bakhos <nuitari@nuitari.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../xloadimage/files/xloadimage-4.1-c99.patch      | 15 ++++
 media-gfx/xloadimage/xloadimage-4.1-r17.ebuild     | 96 ++++++++++++++++++++++
 2 files changed, 111 insertions(+)