Bug 920758 – dev-qt/qtwebengine-6.6.1 adds -Werror flag on its own (GCC-14-SYSTEM)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-12-27 08:44:59 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-qt/qtwebengine-6.6.1 adds -Werror flag on its own (GCC-14-SYSTEM).
Discovered on: amd64 (internal ref: gcc14_tinderbox)

NOTE:
(GCC-14-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-14 but this bug MAY or MAY NOT BE related to the new compiler
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

[Comment 1 Agostino Sarubbo 2023-12-27 08:45:06 UTC]

Created attachment 880367 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

[Comment 2 Ionen Wolkens 2023-12-27 09:00:33 UTC]

That's only the Gn bootstrap rather than qtwebengine itself, mostly likely from:

src/3rdparty/gn/build/gen.py:
    if not options.allow_warnings:
      cflags.append('-Werror')

Won't bother with this now but I'll have a look next time I update the patchset (it's nice that it's an option, but there's currently no way to pass options to gen.py without patching).

[Comment 3 Larry the Git Cow 2024-01-29 14:38:41 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f87339dac0c5039f8cb15743327bd296e62799a9

commit f87339dac0c5039f8cb15743327bd296e62799a9
Author:     Ionen Wolkens <[e-mail]>
AuthorDate: 2024-01-29 02:25:58 +0000
Commit:     Ionen Wolkens <[e-mail]>
CommitDate: 2024-01-29 14:37:15 +0000

    dev-qt/qtwebengine: update patchset for 6.6 and 6.7 branches
    
    6.6-8 -> 6.6-9 and
    6.7-3 -> 6.7-4 changes:
      Updated:
      * gn-bootstrap.patch (updated to not pass -Werror wrt bug #920758)
      Removed:
      * samurai.patch (unnecessary with the new app-alternatives/ninja)
    
    Meant to do these last time updated patchsets, but forgot to read
    my notes when worked on that. Doing it now so that it will be in
    the 6.6.2 release in ~2 days.
    
    Bug: https://bugs.gentoo.org/920758
    Signed-off-by: Ionen Wolkens <[e-mail]>

 dev-qt/qtwebengine/Manifest                    | 4 ++--
 dev-qt/qtwebengine/qtwebengine-6.6.9999.ebuild | 2 +-
 dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild | 2 +-
 dev-qt/qtwebengine/qtwebengine-6.9999.ebuild   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

[Comment 4 Larry the Git Cow 2024-02-14 12:24:54 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=20add58950c85c206d98e59943bd81b333e40968

commit 20add58950c85c206d98e59943bd81b333e40968
Author:     Ionen Wolkens <[e-mail]>
AuthorDate: 2024-02-14 11:09:33 +0000
Commit:     Ionen Wolkens <[e-mail]>
CommitDate: 2024-02-14 12:22:13 +0000

    dev-qt/qtwebengine: add 6.6.2
    
    Closes: https://bugs.gentoo.org/920758
    Signed-off-by: Ionen Wolkens <[e-mail]>

 dev-qt/qtwebengine/Manifest                 |   1 +
 dev-qt/qtwebengine/qtwebengine-6.6.2.ebuild | 314 ++++++++++++++++++++++++++++
 2 files changed, 315 insertions(+)