Bug 920448

Summary:	git-r3.eclass gentoo commit 142a99106 broke EGIT_OVERRIDE_COMMIT_* with short commit SHA
Product:	Gentoo Linux	Reporter:	Duncan <1i5t5.duncan>
Component:	Eclasses	Assignee:	Michał Górny <mgorny>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	parona, sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=503332 https://bugs.gentoo.org/show_bug.cgi?id=917746
Whiteboard:
Package list:		Runtime testing required:	---

Description Duncan 2023-12-21 07:57:44 UTC

(As in the summary...) gentoo 142a99106 to git-r3.eclass seems to have broken the EGIT_OVERIDE_COMMIT_* feature.

Seems this commit didn't get the usual eclass gentoo-dev list evaluation, or at least I can't find it. =:^(

Attempting to set for instance EGIT_OVERRIDE_COMMIT_PLASMA_LIBPLASMA= (for kde-plasma/libplasma-9999) to any commit, even the current HEAD commit, yields an error attempting to fetch that commit, even when it's already cached locally:

>>> Unpacking source...
* Repository id: plasma_libplasma.git
* Using EGIT_OVERRIDE_COMMIT_PLASMA_LIBPLASMA=2e15a844a
* No support will be provided.
* Fetching https://invent.kde.org/plasma/libplasma.git ...
git fetch https://invent.kde.org/plasma/libplasma.git --prune +refs/heads/*:refs/heads/* +refs/tags/*:refs/tags/* +refs/notes/*:refs/notes/* +refs/pull/*/head:refs/pull/* +HEAD:refs/git-r3/HEAD 2e15a844a
fatal: couldn't find remote ref 2e15a844a

Trying an in-gentoo non-kde live-ebuild, sys-fs/compsize-9999:

>> Unpacking source...
* Repository id: kilobyte_compsize.git
* Using EGIT_OVERRIDE_COMMIT_KILOBYTE_COMPSIZE=ceb17a33e
* No support will be provided.
* Fetching https://github.com/kilobyte/compsize.git ...
git fetch https://github.com/kilobyte/compsize.git --prune +refs/heads/*:refs/heads/* +refs/tags/*:refs/tags/* +refs/notes/*:refs/notes/* +refs/pull/*/head:refs/pull/* +HEAD:refs/git-r3/HEAD ceb17a33e
fatal: couldn't find remote ref ceb17a33e

Locally patching git-r3.eclass to revert 142a99106 allows EGIT_OVERRIDE_COMMIT_* to function as intended.

Comment 1 Sam James archtester

2023-12-21 07:59:20 UTC

(In reply to Duncan from comment #0)
> Seems this commit didn't get the usual eclass gentoo-dev list evaluation, or
> at least I can't find it. =:^(

I actually thought it had but we don't require it if a change feels obvious or unlikely to break things.

Comment 2 Alfred Wingate 2023-12-21 08:09:30 UTC

Managed figure out that is due fetch not accepting short SHA's (while EGIT_CLONE_TYPE=mirror).

EGIT_OVERRIDE_COMMIT_PLASMA_LIBPLASMA="2e15a844a7397025d22a02d5005432ecc369ab12" still works.

Comment 3 Duncan 2023-12-21 08:41:05 UTC

(In reply to Alfred Wingate from comment #2)
> Managed figure out that is due fetch not accepting short SHA's (while
> EGIT_CLONE_TYPE=mirror).
> 
> EGIT_OVERRIDE_COMMIT_PLASMA_LIBPLASMA="2e15a844a7397025d22a02d5005432ecc369ab
> 12" still works.

Useful, thanks.

(Wow you and sam are fast today!  My email client hadn't even fetched the original filing yet (half-hour mail checks) and you guys were already on it!)