Bug 920029 – [guru] dev-cpp/cpprestsdk-2.10.19-r1 adds -Werror flag on its own

• Product: GURU
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-12-15 14:45:18 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-cpp/cpprestsdk-2.10.19 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

[Comment 1 Agostino Sarubbo 2023-12-15 14:45:21 UTC]

Created attachment 879480 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2023-12-17 17:36:08 UTC]

guru_ci has reproduced this issue with version 2.10.19-r1 - Updating summary.

[Comment 3 Larry the Git Cow 2023-12-17 23:08:09 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=102ae60a0ca9167b3ffa33fd6dcf892014bfb143

commit 102ae60a0ca9167b3ffa33fd6dcf892014bfb143
Author:     Jan-Espen Oversand <[e-mail]>
AuthorDate: 2023-12-17 22:51:02 +0000
Commit:     Jan-Espen Oversand <[e-mail]>
CommitDate: 2023-12-17 22:51:51 +0000

    dev-cpp/cpprestsdk: disable werror flag by default
    
    Bug: https://bugs.gentoo.org/920029
    Closes: https://bugs.gentoo.org/920029
    Signed-off-by: Jan-Espen Oversand <[e-mail]>

 ...restsdk-2.10.19-r2.ebuild => cpprestsdk-2.10.19-r3.ebuild} |  1 +
 .../files/cpprestsdk-2.10.19-disable-werror-default.patch     | 11 +++++++++++
 2 files changed, 12 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=102ae60a0ca9167b3ffa33fd6dcf892014bfb143

commit 102ae60a0ca9167b3ffa33fd6dcf892014bfb143
Author:     Jan-Espen Oversand <[e-mail]>
AuthorDate: 2023-12-17 22:51:02 +0000
Commit:     Jan-Espen Oversand <[e-mail]>
CommitDate: 2023-12-17 22:51:51 +0000

    dev-cpp/cpprestsdk: disable werror flag by default
    
    Bug: https://bugs.gentoo.org/920029
    Closes: https://bugs.gentoo.org/920029
    Signed-off-by: Jan-Espen Oversand <[e-mail]>

 ...restsdk-2.10.19-r2.ebuild => cpprestsdk-2.10.19-r3.ebuild} |  1 +
 .../files/cpprestsdk-2.10.19-disable-werror-default.patch     | 11 +++++++++++
 2 files changed, 12 insertions(+)