| Summary: | dev-util/geany-plugins-2.0 - prjorg-sidebar.c: error: returning void from a function with incompatible return type gchar {aka char } [-Wincompatible-p | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Chris Mayo <aklhfex> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aklhfex |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/geany/geany-plugins/issues/1297 | ||
| See Also: |
https://github.com/geany/geany-plugins/issues/1297 https://github.com/geany/geany-plugins/pull/1298 https://github.com/gentoo/gentoo/pull/34823 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 870412 | ||
| Attachments: |
emerge-info.txt
dev-util:geany-plugins-2.0:20231208-022853.log.xz emerge-history.txt.xz environment etc.clang.tar.xz etc.portage.tar.xz logs.tar.xz qlist-info.txt.xz temp.tar.xz casts the return value to gchar** |
||
Created attachment 878225 [details]
emerge-info.txt
Created attachment 878226 [details]
dev-util:geany-plugins-2.0:20231208-022853.log.xz
Created attachment 878227 [details]
emerge-history.txt.xz
Created attachment 878228 [details]
environment
Created attachment 878229 [details]
etc.clang.tar.xz
Created attachment 878230 [details]
etc.portage.tar.xz
Created attachment 878231 [details]
logs.tar.xz
Created attachment 878232 [details]
qlist-info.txt.xz
Created attachment 878233 [details]
temp.tar.xz
Created attachment 878575 [details, diff]
casts the return value to gchar**
They do the same with casting the function at line 903 in pohelper/src/gph-plugin.c so I'm assuming they just forgot to do the same here.
Thanks for the patch and submitting it upstream. I was waiting to see if it got merged, and even if there was a 2.0.1 release (tagged on another PR). Let's not wait any longer. The patch is small and as mentioned repeats code already used. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=719ff4568b6095efcb81a655c6ee6e1e98a7eac1 commit 719ff4568b6095efcb81a655c6ee6e1e98a7eac1 Author: Chris Mayo <aklhfex@gmail.com> AuthorDate: 2024-01-15 19:20:03 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-17 05:44:20 +0000 dev-util/geany-plugins: GCC 14 compatibility Closes: https://bugs.gentoo.org/919446 Signed-off-by: Chris Mayo <aklhfex@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/34823 Signed-off-by: Sam James <sam@gentoo.org> .../files/geany-plugins-2.0-gcc14.patch | 11 ++ dev-util/geany-plugins/geany-plugins-2.0-r1.ebuild | 127 +++++++++++++++++++++ 2 files changed, 138 insertions(+) |
| ^~~~~~~~~~~~~~~~ In file included from /usr/include/gtk-3.0/gtk/gtk.h:277: /usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:742:13: note: declared here 742 | GtkStyle * gtk_widget_get_style (GtkWidget *widget); | ^~~~~~~~~~~~~~~~~~~~ prjorg-sidebar.c: In function 'prjorg_sidebar_get_expanded_paths': prjorg-sidebar.c:1565:16: error: returning 'void **' from a function with incompatible return type 'gchar **' {aka 'char **'} [-Wincompatible-pointer-types] 1565 | return g_ptr_array_free(expanded_paths, FALSE); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop_gnome_systemd-20231123-170505 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-10 [2] x86_64-pc-linux-gnu-14 * clang/llvm (if any): clang version 17.0.6 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/17/bin Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg /usr/lib/llvm/17 17.0.6 Python 3.11.7 Available Ruby profiles: [1] ruby31 (with Rubygems) * Available Rust versions: [1] rust-bin-1.73.0 * The following VMs are available for generation-2: 1) Eclipse Temurin JDK 11.0.20.1_p1 [openjdk-bin-11] 2) Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17] *) Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21] 4) Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8] Available Java Virtual Machines: [1] openjdk-bin-8 [2] openjdk-bin-11 [3] openjdk-bin-17 [4] openjdk-bin-21 system-vm The Glorious Glasgow Haskell Compilation System, version 9.2.8 php cli (if any): go version go1.21.4 linux/amd64 HEAD of ::gentoo commit 577f8e7a1742691ebb00e36a4e9862abb61fdd23 Author: Repository mirror & CI <repomirrorci@gentoo.org> Date: Fri Dec 8 02:02:03 2023 +0000 2023-12-08 02:02:02 UTC emerge -qpvO dev-util/geany-plugins [ebuild N ] dev-util/geany-plugins-2.0 USE="git lua nls -ctags -debugger -enchant -gpg -gtkspell -markdown -pretty-printer -scope -webhelper -workbench" LUA_SINGLE_TARGET="lua5-1"