Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 919296

Summary: media-video/vlc-3.0.20-r2 - access/rdp.c: error: assignment to pDesktopResize {aka int ( )(struct rdp_context )} from incompatible pointer type void (
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED FIXED    
Severity: normal CC: kripton, M.Steel
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=919068
https://bugs.gentoo.org/show_bug.cgi?id=926261
https://github.com/gentoo/gentoo/pull/37111
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 870412    
Attachments: emerge-info.txt
emerge-history.txt.xz
environment
etc.clang.tar.xz
etc.portage.tar.xz
logs.tar.xz
media-video:vlc-3.0.20-r2:20231205-171153.log.xz
qlist-info.txt.xz
temp.tar.xz

Description Toralf Förster gentoo-dev 2023-12-05 17:22:00 UTC
  869 |                 if( strcasecmp( type, "BINARY" ) )
      |                   ^
access/vcd/cdrom.c:871:13: note: here
  871 |             case 1:
      |             ^~~~
access/rdp.c: In function postConnectHandler:
access/rdp.c:238:39: error: assignment to pDesktopResize {aka int (*)(struct rdp_context *)} from incompatible pointer type void (*)(rdpContext *) {aka void (*)(struct rdp_context *)} [-Wincompatible-pointer-types]
  238 |     p_instance->update->DesktopResize = desktopResizeHandler;
      |                                       ^

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome_systemd-20231123-170505

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10
 [2] x86_64-pc-linux-gnu-14 *
clang/llvm (if any):
clang version 17.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/17/bin
Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg
/usr/lib/llvm/17
17.0.6
Python 3.11.7
Available Ruby profiles:
  [1]   ruby31 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.73.0 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17]
*)	Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21]
3)	Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8 
  [2]   openjdk-bin-17 
  [3]   openjdk-bin-21  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.2.8
php cli (if any):
go version go1.21.4 linux/amd64

  HEAD of ::gentoo
commit cf0cf926dd55fd2fc8b24d820bc685e0aba9415e
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Tue Dec 5 16:17:00 2023 +0000

    2023-12-05 16:17:00 UTC

emerge -qpvO media-video/vlc
[ebuild     U ] media-video/vlc-3.0.20-r2 [3.0.20-r1] USE="X a52 alsa dbus dts dvbpsi dvd encode ffmpeg flac fontconfig gcrypt gstreamer gui ieee1394 jpeg keyring libnotify libsamplerate lirc lua mad mpeg ncurses ogg png pulseaudio rdp speex ssl svg taglib theora truetype udev v4l vdpau wayland x264 xml zeroconf -aom -archive -aribsub -bidi -bluray -cddb -chromaprint -chromecast -dav1d -dc1394 -debug (-directx) -faad -fdk -fluidsynth -gme -jack -kate -libass -libcaca -libtar -libtiger -linsys -live -macosx-notifications -matroska -modplug -mp3 -mtp -musepack -nfs -omxil -optimisememory -opus -projectm -run-as-root -samba -sdl-image -sftp -shout -sid -skins -soxr -srt -test -tremor -twolame -upnp -vaapi -vnc -vpx -x265 -zvbi" CPU_FLAGS_X86="mmx sse" LUA_SINGLE_TARGET="lua5-1"
Comment 1 Toralf Förster gentoo-dev 2023-12-05 17:22:01 UTC
Created attachment 877585 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-12-05 17:22:05 UTC
Created attachment 877586 [details]
emerge-history.txt.xz
Comment 3 Toralf Förster gentoo-dev 2023-12-05 17:22:06 UTC
Created attachment 877587 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2023-12-05 17:22:07 UTC
Created attachment 877588 [details]
etc.clang.tar.xz
Comment 5 Toralf Förster gentoo-dev 2023-12-05 17:22:09 UTC
Created attachment 877589 [details]
etc.portage.tar.xz
Comment 6 Toralf Förster gentoo-dev 2023-12-05 17:22:10 UTC
Created attachment 877590 [details]
logs.tar.xz
Comment 7 Toralf Förster gentoo-dev 2023-12-05 17:22:11 UTC
Created attachment 877591 [details]
media-video:vlc-3.0.20-r2:20231205-171153.log.xz
Comment 8 Toralf Förster gentoo-dev 2023-12-05 17:22:12 UTC
Created attachment 877592 [details]
qlist-info.txt.xz
Comment 9 Toralf Förster gentoo-dev 2023-12-05 17:22:13 UTC
Created attachment 877593 [details]
temp.tar.xz
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-06 07:02:26 UTC
hmm..

commit 95e7bba6105bd8c2b8ea9cabc02c8dfe7411cab2
Author: Juliane de Sartiges <jill@videolabs.io>
Date:   Wed Jul 27 09:32:25 2022 +0200

    freerdp: update to freerdp2 api
Comment 11 Max Steel 2024-07-02 07:46:18 UTC
I got the same error on my wsl2.
[I] media-video/vlc
     Available versions:  3.0.20-r11(0/5-9)^t **3.0.9999(0/5-9)*l^t **9999(0/12-9)*l^t {+X a52 alsa aom archive aribsub bidi bluray cddb chromaprint chromecast dav1d dbus dc1394 debug directx dts +dvbpsi dvd +encode faad fdk +ffmpeg flac fluidsynth fontconfig +gcrypt gme gstreamer +gui ieee1394 jack jpeg kate keyring kms libass libcaca libnotify libplacebo +libsamplerate libtar libtiger linsys lirc live loudness lua macosx-notifications mad matroska modplug mp3 mpeg mtp musepack ncurses nfs ogg omxil optimisememory opus png projectm pulseaudio rdp run-as-root samba sdl-image sftp shout sid skins soxr speex srt ssl svg taglib test theora tremor truetype twolame udev upnp v4l vaapi vdpau vnc vpx wayland x264 x265 xml zeroconf zvbi CPU_FLAGS_ARM="neon" CPU_FLAGS_PPC="altivec" CPU_FLAGS_X86="mmx sse" LUA_SINGLE_TARGET="+lua5-1"}
     Installed versions:  3.0.20-r11(0/5-9)^t(09:41:09 07/02/24)(X a52 alsa bluray cddb dbus dts dvbpsi dvd encode ffmpeg flac fontconfig gcrypt gui jpeg libass libnotify libsamplerate mad matroska modplug mp3 mpeg mtp ncurses ogg opus png projectm pulseaudio rdp samba ssl svg theora tremor truetype udev vnc vpx x264 xml -aom -archive -aribsub -bidi -chromaprint -chromecast -dav1d -dc1394 -debug -directx -faad -fdk -fluidsynth -gme -gstreamer -ieee1394 -jack -kate -keyring -libcaca -libtar -libtiger -linsys -lirc -live -lua -macosx-notifications -musepack -nfs -omxil -optimisememory -run-as-root -sdl-image -sftp -shout -sid -skins -soxr -speex -srt -taglib -test -twolame -upnp -v4l -vaapi -vdpau -wayland -x265 -zeroconf -zvbi CPU_FLAGS_ARM="-neon" CPU_FLAGS_PPC="-altivec" CPU_FLAGS_X86="mmx sse" LUA_SINGLE_TARGET="lua5-1")
     Homepage:            https://www.videolan.org/vlc/
     Description:         Media player and framework with support for most multimedia files and streaming

After i deactivated rdp it compiled successful.
Comment 12 Larry the Git Cow gentoo-dev 2024-07-03 14:26:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c12512ff0193c3abe2f765f799c94b4af3921e60

commit c12512ff0193c3abe2f765f799c94b4af3921e60
Author:     Martin Mokry <martin-kokos@protonmail.com>
AuthorDate: 2024-06-10 18:38:14 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2024-07-03 14:26:00 +0000

    media-video/vlc: add 3.0.21, modern C fix
    
    Add patch with upstream commit:
    https://code.videolan.org/videolan/vlc/-/commit/95e7bba6105bd8c2b8ea9cabc02c8dfe7411cab2
    
    Closes: https://bugs.gentoo.org/919296
    Signed-off-by: Martin Mokry <martin-kokos@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/37111
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 media-video/vlc/Manifest                         |   1 +
 media-video/vlc/files/vlc-3.0.21-freerdp-2.patch | 230 ++++++++++
 media-video/vlc/vlc-3.0.21.ebuild                | 516 +++++++++++++++++++++++
 3 files changed, 747 insertions(+)