Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 919228

Summary: dev-util/xdelta-1.1.4-r3 - xdmain.c: error: passing argument 1 of gzread from incompatible pointer type [-Wincompatible-pointer-types]
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Michał Górny <mgorny>
Status: RESOLVED FIXED    
Severity: normal CC: jy6x2b32pie9
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 870412    
Attachments: emerge-info.txt
dev-util:xdelta-1.1.4-r3:20231204-050349.log
emerge-history.txt
environment
etc.clang.tar.xz
etc.portage.tar.xz
logs.tar.xz
qlist-info.txt.xz
temp.tar.xz
added fd for gzip file to opaque file handle
ebuild with patch

Description Toralf Förster gentoo-dev 2023-12-04 20:17:45 UTC
  423 |             else if (end && g_strcasecmp (end, "K") == 0)
      |             ^~~~
/usr/include/glib-2.0/glib/gstrfuncs.h:268:23: note: declared here
  268 | gint                  g_strcasecmp     (const gchar *s1,
      |                       ^~~~~~~~~~~~
xdmain.c: In function xd_gzread:
xdmain.c:523:20: error: passing argument 1 of gzread from incompatible pointer type [-Wincompatible-pointer-types]
  523 |   return gzread (fh->in, buf, nbyte) == nbyte;
      |                  ~~^~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no_multilib_systemd_merged_usr-20231128-165524

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-14 *
clang/llvm (if any):
clang version 17.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/17/bin
Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg
/usr/lib/llvm/17
17.0.6
Python 3.11.6
Available Ruby profiles:
  [1]   ruby31 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.73.0 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17]
*)	Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21]
3)	Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8 
  [2]   openjdk-bin-17 
  [3]   openjdk-bin-21  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.2.8
php cli (if any):
go version go1.21.4 linux/amd64

  HEAD of ::gentoo
commit e6355ec1ee123a5a2b7155da486ba61988b0a30c
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Mon Dec 4 03:16:56 2023 +0000

    2023-12-04 03:16:55 UTC

emerge -qpvO dev-util/xdelta
[ebuild   R   ] dev-util/xdelta-3.0.11-r1  USE="lzma -examples"
Comment 1 Toralf Förster gentoo-dev 2023-12-04 20:17:46 UTC
Created attachment 877161 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-12-04 20:17:47 UTC
Created attachment 877162 [details]
dev-util:xdelta-1.1.4-r3:20231204-050349.log
Comment 3 Toralf Förster gentoo-dev 2023-12-04 20:17:48 UTC
Created attachment 877163 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2023-12-04 20:17:49 UTC
Created attachment 877164 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2023-12-04 20:17:50 UTC
Created attachment 877165 [details]
etc.clang.tar.xz
Comment 6 Toralf Förster gentoo-dev 2023-12-04 20:17:51 UTC
Created attachment 877166 [details]
etc.portage.tar.xz
Comment 7 Toralf Förster gentoo-dev 2023-12-04 20:17:52 UTC
Created attachment 877167 [details]
logs.tar.xz
Comment 8 Toralf Förster gentoo-dev 2023-12-04 20:17:53 UTC
Created attachment 877168 [details]
qlist-info.txt.xz
Comment 9 Toralf Förster gentoo-dev 2023-12-04 20:17:55 UTC
Created attachment 877169 [details]
temp.tar.xz
Comment 10 NHO 2024-03-25 14:43:59 UTC
Created attachment 888549 [details, diff]
added fd for gzip file to opaque file handle
Comment 11 NHO 2024-03-25 14:50:22 UTC
Created attachment 888551 [details]
ebuild with patch

Tests don't work, so not sure if this works. Based on library documentation, should.
There's only one user of xdelta:0 - games-util/loki_patch and it's next.
Comment 12 Larry the Git Cow gentoo-dev 2024-03-25 22:42:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=647cf6b4aa4ca620121a4c15513c9999e22fedcd

commit 647cf6b4aa4ca620121a4c15513c9999e22fedcd
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2024-03-25 22:32:12 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2024-03-25 22:42:30 +0000

    dev-util/xdelta: Fix building 1.1.4 with GCC 14
    
    Thanks to NHOrus for the patch.
    
    Closes: https://bugs.gentoo.org/919228
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 dev-util/xdelta/files/xdelta-1.1.4-gzip.patch | 59 +++++++++++++++++++++++++++
 dev-util/xdelta/xdelta-1.1.4-r4.ebuild        | 43 +++++++++++++++++++
 2 files changed, 102 insertions(+)