| Summary: | app-shells/zsh-5.9-r4: fails to compile (termcap.c:45:14: error: conflicting types for ‘boolcodes’; have ‘char *[]’) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sam James <sam> |
| Component: | Current packages | Assignee: | Matthias Maier <tamiko> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | floppym, nvinson234 |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | fixed in 5.9-r5 | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 870412 | ||
| Attachments: | build.log | ||
|
Description
Sam James
2023-12-02 02:23:54 UTC
I wonder if a configure test got confused here with the new GCC changes. (In reply to Sam James from comment #1) > I wonder if a configure test got confused here with the new GCC changes. yep configure:11193: checking if boolcodes is available configure:11206: x86_64-pc-linux-gnu-gcc -o conftest -O2 -pipe -march=native -fdiagnostics-color=always -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 conftest.c -lgdbm -L/usr/lib64 -lpcre -ldl -lncursesw -ltinfow -ltinfow -lrt -lm -lc >&5 conftest.c: In function 'main': conftest.c:248:15: error: initialization of 'char **' from incompatible pointer type 'const char * const*' [-Wincompatible-pointer-types] 248 | char **test = boolcodes; puts(*test); | ^~~~~~~~~ configure:11206: $? = 1 also
configure:11293: checking if numnames is available
configure:11306: x86_64-pc-linux-gnu-gcc -o conftest -O2 -pipe -march=native -fdiagnostics-color=always -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 conftest.c -lgdbm -L/usr/lib64 -lpcre
-ldl -lncursesw -ltinfow -ltinfow -lrt -lm -lc >&5
conftest.c: In function 'main':
conftest.c:248:15: error: initialization of 'char **' from incompatible pointer type 'const char * const*' [-Wincompatible-pointer-types]
248 | char **test = numnames; puts(*test);
| ^~~~~~~~
configure:11306: $? = 1
configure:11318: checking if strnames is available
configure:11331: x86_64-pc-linux-gnu-gcc -o conftest -O2 -pipe -march=native -fdiagnostics-color=always -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 conftest.c -lgdbm -L/usr/lib64 -lpcre
-ldl -lncursesw -ltinfow -ltinfow -lrt -lm -lc >&5
conftest.c: In function 'main':
conftest.c:248:15: error: initialization of 'char **' from incompatible pointer type 'const char * const*' [-Wincompatible-pointer-types]
248 | char **test = strnames; puts(*test);
| ^~~~~~~~
configure:11331: $? = 1
so 3 tests need fixing
Aside: when fixing this, we should pull in https://src.fedoraproject.org/rpms/zsh/blob/rawhide/f/0003-zsh-fix-module-loading-problem-with-full-RELRO.patch. There's two "competing" patches for this: * Florian's at https://www.zsh.org/mla/workers/2023/msg01112.html * username234's at https://www.zsh.org/mla/workers/2023/msg01127.html The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24e0dd5fff14aee16dab340be37fd345b804c0c4 commit 24e0dd5fff14aee16dab340be37fd345b804c0c4 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-12-16 07:40:31 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-12-16 07:44:23 +0000 app-shells/zsh: fix modern C configure issue, fix relro plugin issue * Fix configure issue with stricter C compilers which leads to build failure later on in the build * Fix plugin use w/ relro Closes: https://bugs.gentoo.org/919001 Signed-off-by: Sam James <sam@gentoo.org> app-shells/zsh/files/zsh-5.9-c99.patch | 45 ++++++ app-shells/zsh/files/zsh-5.9-relro.patch | 71 +++++++++ app-shells/zsh/zsh-5.9-r5.ebuild | 245 +++++++++++++++++++++++++++++++ 3 files changed, 361 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5f7dc3c62fb96e3cfebc55adc4f112553e604b06 commit 5f7dc3c62fb96e3cfebc55adc4f112553e604b06 Author: Andreas K. Hüttel <dilfridge@gentoo.org> AuthorDate: 2024-10-31 15:34:15 +0000 Commit: Andreas K. Hüttel <dilfridge@gentoo.org> CommitDate: 2024-10-31 15:34:38 +0000 app-shells/zsh: drop 5.9-r3, 5.9-r4, 5.9-r5 Bug: https://bugs.gentoo.org/919001 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> app-shells/zsh/zsh-5.9-r3.ebuild | 238 ------------------------------------- app-shells/zsh/zsh-5.9-r4.ebuild | 242 -------------------------------------- app-shells/zsh/zsh-5.9-r5.ebuild | 245 --------------------------------------- 3 files changed, 725 deletions(-) |