Bug 918668

Summary:	media-libs/webrtc-audio-processing-1.3-r1 fails to build with musl: ile_wrapper.h:86:21: error: 'int64_t' has not been declared
Product:	Gentoo Linux	Reporter:	Sven E. <dark>
Component:	Current packages	Assignee:	Mart Raudsepp <leio>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://gitlab.freedesktop.org/pulseaudio/webrtc-audio-processing/-/merge_requests/37 https://gitlab.freedesktop.org/pulseaudio/webrtc-audio-processing/-/merge_requests/38
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	webrtc-audio-processing-musl.patch webrtc-audio-processing-musl.patch

Description Sven E. 2023-11-27 19:01:16 UTC

The int64_t supposedly is used to holf file offsets, question is, if it should rather be off_t or if cstdint should instead be included.

Include-section in file_wrapper.h:
#include <stddef.h>
#include <stdio.h>

#include <string>

None of this explicitly would provide int64_t.


Reproducible: Always

Comment 1 Sven E. 2023-11-27 19:02:42 UTC

Created attachment 875838 [details, diff]
webrtc-audio-processing-musl.patch

iFast fix adding in cstdint include

Comment 2 Sven E. 2023-11-27 19:18:28 UTC

Created attachment 875840 [details, diff]
webrtc-audio-processing-musl.patch

iPatch Variant resorting to off_t, file wrapper ist compiled with -D_FILE_OFFSET_BITS=54 anyway.

Comment 3 Alfred Wingate 2023-11-28 12:30:38 UTC

Two pull requests with the same change, both with no response from upstream.

Comment 4 Larry the Git Cow gentoo-dev

2024-01-02 04:40:10 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=29cd0e622b574df6adff5704ab4e220709619767

commit 29cd0e622b574df6adff5704ab4e220709619767
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-02 04:36:56 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-02 04:39:17 +0000

    media-libs/webrtc-audio-processing: fix x86 w/o SSE
    
    Tested with CFLAGS="-O2" CFLAGS_x86="-m32 -O2 -mno-sse -march=i686 -fcf-protection=none" e webrtc-audio-processing-1.3-r3.ebuild clean compile.
    
    Closes: https://bugs.gentoo.org/918668
    Closes: https://bugs.gentoo.org/921140
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/webrtc-audio-processing-1.3-musl.patch   | 34 ++++++++++++++++++
 .../webrtc-audio-processing-1.3-x86-no-sse.patch   | 13 +++++++
 .../webrtc-audio-processing-1.3-r3.ebuild          | 40 ++++++++++++++++++++++
 3 files changed, 87 insertions(+)