| Summary: | media-video/mplayer-1.5_p20230618 - libmpcodecs/mp_image.c: error: INT_MAX undeclared (first use in this function) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cctsurf, leonchik1976, orodruinlair, rdalek1967, robert, vityokster |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tar.xz logs.tar.xz media-video:mplayer-1.5_p20230618:20231124-044610.log qlist-info.txt temp.tar.xz Fixes INT_MAX undeclared bug |
||
Created attachment 875478 [details]
emerge-info.txt
Created attachment 875479 [details]
emerge-history.txt
Created attachment 875480 [details]
environment
Created attachment 875481 [details]
etc.portage.tar.xz
Created attachment 875482 [details]
logs.tar.xz
Created attachment 875483 [details]
media-video:mplayer-1.5_p20230618:20231124-044610.log
Created attachment 875484 [details]
qlist-info.txt
Created attachment 875485 [details]
temp.tar.xz
Created attachment 875857 [details, diff]
Fixes INT_MAX undeclared bug
The attached patch fixes the issue. It just adds an #include <limits.h> to mp_image.c
Dunno if this is the "proper" way to fix it, but it does work.
(In reply to Robert Schultz from comment #9) > Created attachment 875857 [details, diff] [details, diff] > Fixes INT_MAX undeclared bug > > The attached patch fixes the issue. It just adds an #include <limits.h> to > mp_image.c > Dunno if this is the "proper" way to fix it, but it does work. yes, can confirm patch works for me (In reply to Robert Schultz from comment #9) > Created attachment 875857 [details, diff] [details, diff] > Fixes INT_MAX undeclared bug > > The attached patch fixes the issue. It just adds an #include <limits.h> to > mp_image.c > Dunno if this is the "proper" way to fix it, but it does work. Confirm too. Builds successfully (In reply to Robert Schultz from comment #9) > Created attachment 875857 [details, diff] [details, diff] > Fixes INT_MAX undeclared bug > > The attached patch fixes the issue. It just adds an #include <limits.h> to > mp_image.c > Dunno if this is the "proper" way to fix it, but it does work. It worked for me as well. I might add, this seems to affect both versions of mplayer in the tree. This needs to be fixed when possible. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa1593152d4a210b8ac3327557620746b6ddb152 commit fa1593152d4a210b8ac3327557620746b6ddb152 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-12-06 08:28:04 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-12-06 08:31:40 +0000 media-video/mplayer: backport gcc-13 fix The snapshot I just pushed (1.5_p20231206) will fix it for ~arch users, but let's backport this for stable. Bug: https://bugs.gentoo.org/918113 Signed-off-by: Sam James <sam@gentoo.org> media-video/mplayer/files/mplayer-1.5_p20230618-gcc13.patch | 11 +++++++++++ media-video/mplayer/mplayer-1.5_p20230618.ebuild | 4 ++++ 2 files changed, 15 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e69018682821d282dcfa0c3161c0ea8359b795c5 commit e69018682821d282dcfa0c3161c0ea8359b795c5 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-12-06 08:25:39 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-12-06 08:31:39 +0000 media-video/mplayer: add 1.5_p20231206 Bug: https://bugs.gentoo.org/918113 Signed-off-by: Sam James <sam@gentoo.org> media-video/mplayer/Manifest | 1 + media-video/mplayer/mplayer-1.5_p20231206.ebuild | 641 +++++++++++++++++++++++ media-video/mplayer/mplayer-9999.ebuild | 23 +- 3 files changed, 658 insertions(+), 7 deletions(-) |
too long lines were shrinked: | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ x86_64-pc-linux-gnu-gcc -MMD -MP -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -D_ISOC99_SOURCE -I. -Iffmpeg -O3 -pipe -march=native -fno-diagnostics-color -fno-tree-vec x86_64-pc-linux-gnu-gcc -MMD -MP -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -D_ISOC99_SOURCE -I. -Iffmpeg -O3 -pipe -march=native -fno-diagnostics-color -fno-tree-vec x86_64-pc-linux-gnu-gcc -MMD -MP -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -D_ISOC99_SOURCE -I. -Iffmpeg -O3 -pipe -march=native -fno-diagnostics-color -fno-tree-vec libmpcodecs/mp_image.c: In function 'mp_image_alloc_planes': libmpcodecs/mp_image.c:39:39: error: 'INT_MAX' undeclared (first use in this function) 39 | if ((unsigned int)mpi->height + 2 > INT_MAX || | ^~~~~~~ ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop_plasma-20231123-152703 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-13 * clang/llvm (if any): /usr/lib/llvm/17 17.0.5 Python 3.11.6 Available Ruby profiles: [1] ruby31 (with Rubygems) * Available Rust versions: [1] rust-bin-1.73.0 * The Glorious Glasgow Haskell Compilation System, version 9.2.8 php cli (if any): HEAD of ::gentoo commit fb883c10def2e7a72c7210e39a7d445ee1fcdf72 Author: Repository mirror & CI <repomirrorci@gentoo.org> Date: Fri Nov 24 00:16:58 2023 +0000 2023-11-24 00:16:57 UTC emerge -qpvO media-video/mplayer [ebuild N ] media-video/mplayer-1.5_p20230618 USE="X a52 alsa cdio dts dvd dvdnav enca encode iconv ipv6 jpeg libass mng mp3 network opengl osdmenu png pulseaudio sdl shm truetype unicode vcd vorbis x264 xscreensaver xv xvid -aalib (-aqua) -bidi -bl -bluray -bs2b -cddb -cdparanoia -cpudetection -debug -dga -doc -dv -dvb -faac -faad -fbcon -ftp -ggi -gsm -jack -joystick -ladspa -libcaca -libmpeg2 -lirc -live -lzo -mad -md5sum -nas -openal -oss -pnm -pvr -radio -rar -rtc -rtmp -samba (-selinux) -speex -tga -theora -toolame -tremor -twolame -v4l -vdpau (-vidix) -xinerama -yuv4mpeg -zoran" CPU_FLAGS_X86="avx avx2 fma3 mmx mmxext sse sse2 sse3 sse4_1 sse4_2 ssse3 -3dnow -3dnowext -fma4 -xop" VIDEO_CARDS="-mga"