Bug 917419

Summary:	mail-client/thunderbird-115.4.1 redefines _FORTIFY_SOURCE
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Mozilla Gentoo Team <mozilla>
Status:	CONFIRMED ---
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=910071
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	847148

Description Agostino Sarubbo gentoo-dev

2023-11-16 11:48:28 UTC

This is an example of what I can see during build:

77:46.64 /usr/lib/llvm/16/bin/x86_64-pc-linux-gnu-clang++-16 -o Unified_cpp_windowwatcher0.o -c  -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird_build/dist/stl_wrappers -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird_build/dist/system_wrappers -include /tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird-115.4.1/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird-115.4.1/toolkit/components/windowwatcher -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird_build/toolkit/components/windowwatcher -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird-115.4.1/docshell/base -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird-115.4.1/dom/base -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird_build/ipc/ipdl/_ipdlheaders -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird-115.4.1/ipc/chromium/src -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird_build/dist/include -I/usr/include/nspr -I/usr/include/nss -I/usr/include/nspr -I/tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird_build/dist/include/nss -I/usr/include/libpng16 -I/usr/include/pixman-1 -DMOZILLA_CLIENT -include /tmp/portage/mail-client/thunderbird-115.4.1/work/thunderbird_build/mozilla-config.h -fno-sized-deallocation -fno-aligned-new -march=x86-64 -msse4.2 -fno-stack-protector -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g0 -O2 -fomit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/Unified_cpp_windowwatcher0.o.pp  -fcolor-diagnostics  Unified_cpp_windowwatcher0.cpp


I didn't see if '-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2' are added by USE="hardened" or not.

[ebuild   R    ] mail-client/thunderbird-115.4.1::gentoo  USE="X clang dbus hardened openh264 pulseaudio system-av1 system-harfbuzz system-jpeg system-libevent system-librnp system-libvpx system-png system-webp -debug -eme-free -hwaccel -jack -libproxy -lto (-pgo) (-selinux) -sndio (-system-icu) (-system-python-libs) -wayland -wifi" L10N="en-GB -af -ar -ast -be -bg -br -ca -cak -cs -cy -da -de -dsb -el -en-CA -es-AR -es-ES -es-MX -et -eu -fi -fr -fy -ga -gd -gl -he -hr -hsb -hu -id -is -it -ja -ka -kab -kk -ko -lt -lv -ms -nb -nl -nn -pa -pl -pt-BR -pt-PT -rm -ro -ru -sk -sl -sq -sr -sv -th -tr -uk -uz -vi -zh-CN -zh-TW" 0 KiB

Comment 1 Joonas Niilola gentoo-dev

2023-11-16 12:32:25 UTC

Bug 910071 - I wonder if I was supposed to sync it to 115esr, or the next upcoming 128esr.

Comment 2 Sam James archtester

2023-11-25 00:34:12 UTC

I'm not aware of any bug fixes for FF/TB needed so syncing it to any verison should be fine.