Bug 917338

Summary:	sys-apps/irqbalance-1.9.3 fails to ban irq
Product:	Gentoo Linux	Reporter:	Michelangelo Scopelliti <kernelpanic>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	CC:	flow
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/Irqbalance/irqbalance/issues/271
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	emerge --info

Description Michelangelo Scopelliti 2023-11-14 15:48:10 UTC

Created attachment 874788 [details]
emerge --info

I recently discovered in /var/log/messages a lot of 

/usr/sbin/irqbalance: Cannot change IRQ XX affinity: Input/output error

According to upstream, this is expected:

https://github.com/Irqbalance/irqbalance/issues/271

The upstream suggestion is to ban the irqs.

This should be done, I suppose, in /etc/conf.d/irqbalance, where the variable "IRQBALANCE_BANNED_INTERRUPTS" should be populated with IRQs to ban. But, as far as I can thell, such a variable is not used, nor is mentioned in the man page -- where the indications for banning an IRQ are to indicate them one by one.

I tried to populate IRQBALANCE_BANNED_INTERRUPTS both with comma- and space-separated values, but the messages are still present after launching the service.

Comment 1 Sam James archtester

2023-11-14 15:50:26 UTC

May need to pass them as extra args like https://github.com/Irqbalance/irqbalance/blob/d08fb4d1b5060fc52dfdcdea412aa1a06bcda0bd/irqbalance.1#L62

Comment 2 Michelangelo Scopelliti 2023-11-14 18:56:31 UTC

(In reply to Sam James from comment #1)
> May need to pass them as extra args like
> https://github.com/Irqbalance/irqbalance/blob/
> d08fb4d1b5060fc52dfdcdea412aa1a06bcda0bd/irqbalance.1#L62

Yes, of course. But that is not the point; the point is that the current /etc/conf.d/irqbalance file is not working, and gives incorrect information.

Comment 3 simon 2024-01-09 08:11:54 UTC

The environment variable was dropped from upstream and should be removed from the supplied config example/blueprint as well.
See also https://www.suse.com/support/kb/doc/?id=000018665

Comment 4 Sam James archtester

2024-01-09 08:18:03 UTC

(In reply to Michelangelo Scopelliti from comment #2)
> (In reply to Sam James from comment #1)
> > May need to pass them as extra args like
> > https://github.com/Irqbalance/irqbalance/blob/
> > d08fb4d1b5060fc52dfdcdea412aa1a06bcda0bd/irqbalance.1#L62
> 
> Yes, of course. But that is not the point; the point is that the current
> /etc/conf.d/irqbalance file is not working, and gives incorrect information.

(It was more of a comment for what we need to do.)

Comment 5 Larry the Git Cow gentoo-dev

2024-03-28 04:47:49 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e1b0adc1eb3618207a8315e90fb53b17d489994

commit 3e1b0adc1eb3618207a8315e90fb53b17d489994
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-28 04:46:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-28 04:46:32 +0000

    sys-apps/irqbalance: drop obsolete option from OpenRC conf.d
    
    IRQBALANCE_BANNED_INTERRUPTS was removed upstream. We could implement
    it as a shim for upstream's --banirq option but I don't see the point, people
    can pass that via the other variable anyway.
    
    Bug: https://github.com/Irqbalance/irqbalance/issues/271
    Closes: https://bugs.gentoo.org/917338
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/irqbalance/files/irqbalance.confd-2 | 16 ++++++++++++++++
 sys-apps/irqbalance/irqbalance-1.9.4.ebuild  |  2 +-
 2 files changed, 17 insertions(+), 1 deletion(-)