Bug 917323

Summary:	sci-electronics/kicad disable building of tests
Product:	Gentoo Linux	Reporter:	jospezial <jospezial>
Component:	Current packages	Assignee:	Zoltan Puskas <zoltan>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kostadinshishmanov, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/33944
Whiteboard:
Package list:		Runtime testing required:	---

Description jospezial 2023-11-14 06:04:54 UTC

In CMakeLists.txt I found the options to disable building of tests.

If I add

-DKICAD_SPICE_QA="OFF"
-DKICAD_BUILD_QA_TESTS="OFF"

1842 instead of 1995 source files to compile for kicad-9999.
Saves some compilation time.

Comment 1 jospezial 2023-11-16 17:23:07 UTC

please assign to
Zoltan Puskas
zoltan@sinustrom.info

Comment 2 Sam James archtester

2023-11-17 11:46:14 UTC

Please don't CC manually. Just wait.

Comment 3 Zoltan Puskas 2023-11-23 10:17:31 UTC

This is a good find thanks. Actually -DKICAD_BUILD_QA_TESTS="OFF" can be also applied to non 9999 versions of KiCad. I will gate these options behind the usual USE=test.

Comment 4 Larry the Git Cow gentoo-dev

2023-11-28 16:38:15 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=369713e2349ce8197ea5cbfdbac319584fe81025

commit 369713e2349ce8197ea5cbfdbac319584fe81025
Author:     Zoltan Puskas <zoltan@sinustrom.info>
AuthorDate: 2023-11-23 10:19:47 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-11-28 16:36:45 +0000

    sci-electronics/kicad: Add USE=test and use it to control building QA tests
    
    Closes: https://bugs.gentoo.org/917323
    Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sci-electronics/kicad/kicad-7.0.8.ebuild | 6 +++++-
 sci-electronics/kicad/kicad-7.0.9.ebuild | 6 +++++-
 sci-electronics/kicad/kicad-9999.ebuild  | 7 ++++++-
 3 files changed, 16 insertions(+), 3 deletions(-)