Bug 917152

Summary:	net-misc/l7-protocols-2009.05.28-r1: Ebuild prints weird output.
Product:	Gentoo Linux	Reporter:	Teika kazura <teika>
Component:	Current packages	Assignee:	Andrew Savchenko <bircoph>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Teika kazura 2023-11-11 06:13:59 UTC

The source preparation phase of this ebuild is obviously wrong, printing:
---------------------------------------------------------------------------
[snip]
>>> Source unpacked in /tmp/build/net-misc/l7-protocols-2009.05.28-r1/work
>>> Preparing source in /tmp/build/net-misc/l7-protocols-2009.05.28-r1/work/l7-protocols-2009-05-28 ...
#!/bin/bash

# "man 1 time" for details
export TIME="%U seconds"

add()
{
	if ! dc -e ""; then
	        echo you do not have dc, so I cannot add these numbers...
	        exit 1
	fi

[snip]

        rm tmp.$$
else
        echo Please specify \"all\", \"print\" or \"real\"> /dev/stderr
        exit 1
fi
 * Replacing obsolete head/tail with POSIX compliant ones
 *  - fixed testing/doallspeeds.sh
 *  - fixed testing/test_match.sh
 *  - fixed testing/timeit.sh
>>> Source prepared.
>>> Configuring source in /tmp/build/net-misc/l7-protocols-2009.05.28-r1/work/l7-protocols-2009-05-28 ...
---------------------------------------------------------------------------
Wow.

Thanks a lot.
# I don't need this package, and I accidentaly came across. :)


Reproducible: Always

Comment 1 Sam James archtester

2023-11-11 06:30:05 UTC

Yeah, there's an -i missing from one of the seds.

Comment 2 Larry the Git Cow gentoo-dev

2023-11-11 06:31:40 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36ebed561d63bb5c928149341f958cc9ad8378a7

commit 36ebed561d63bb5c928149341f958cc9ad8378a7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-11-11 06:31:12 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-11 06:31:12 +0000

    net-misc/l7-protocols: fix broken sed
    
    Seems to just be used for tests so no revbump, not that I really looked into the
    package.
    
    Closes: https://bugs.gentoo.org/917152
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/l7-protocols/l7-protocols-2009.05.28-r1.ebuild | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comment 3 Sam James archtester

2023-11-11 06:31:48 UTC

Good spot, thank you!