Summary: | games-action/prismlauncher-8.0 - error: Source option 7 is no longer supported. Use 8 or later. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Thiago <flowlnlnln> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andrewammerlaan, germtoo, parona, proxy-maint, w.iron.zombie, zhuyifei1999 |
Priority: | Normal | Keywords: | PATCH, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://github.com/PrismLauncher/PrismLauncher/issues/1749#issuecomment-1783131783 https://github.com/PrismLauncher/PrismLauncher/pull/1013 https://github.com/gentoo/gentoo/pull/36212 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 929118 | ||
Bug Blocks: | 916396 | ||
Attachments: |
emerge-info.txt
emerge-history.txt.xz environment etc.clang.tar.xz etc.portage.tar.xz games-action:prismlauncher-8.0:20231109-110213.log qlist-info.txt.xz temp.tar.xz prismlauncher-8.0-CMakeLists-java21.patch |
Description
Toralf Förster
2023-11-09 11:07:40 UTC
Created attachment 874351 [details]
emerge-info.txt
Created attachment 874352 [details]
emerge-history.txt.xz
Created attachment 874353 [details]
environment
Created attachment 874354 [details]
etc.clang.tar.xz
Created attachment 874355 [details]
etc.portage.tar.xz
Created attachment 874356 [details]
games-action:prismlauncher-8.0:20231109-110213.log
Created attachment 874357 [details]
qlist-info.txt.xz
Created attachment 874358 [details]
temp.tar.xz
Created attachment 874571 [details, diff]
prismlauncher-8.0-CMakeLists-java21.patch
With the attached source patch at least is compiles.
Do not forget to inherit java-pkg-2.eclass
Should not block java21 stabilization. *** Bug 923810 has been marked as a duplicate of this bug. *** (In reply to Volkmar W. Pogatzki from comment #9) > Created attachment 874571 [details, diff] [details, diff] > prismlauncher-8.0-CMakeLists-java21.patch > > With the attached source patch at least is compiles. > Do not forget to inherit java-pkg-2.eclass Thanks! Going to apply this patch conditional to whether the openjdk compiler version is 20 or up as bumping the java version from 7 to 8 is known upstream to sometimes cause problems with older Minecraft versions or old forge versions. I tested myself and I can still successfully launch and play Minecraft 1.7.10 with the latest forge after applying your patch. I believe this is the best solution as users won't face compile failure when the system java compiler is openjdk-21, yet it is still possible to play ancient Minecraft version by choosing an older java compiler. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2dad9dd76c2380c45c168a447a1742240d46e1dd commit 2dad9dd76c2380c45c168a447a1742240d46e1dd Author: Andrew Ammerlaan <andrewammerlaan@gentoo.org> AuthorDate: 2024-03-11 21:23:01 +0000 Commit: Andrew Ammerlaan <andrewammerlaan@gentoo.org> CommitDate: 2024-03-11 21:24:38 +0000 games-action/prismlauncher: add 8.2 Bug: https://bugs.gentoo.org/917072 Bug: https://bugs.gentoo.org/873142 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org> games-action/prismlauncher/Manifest | 1 + .../files/prismlauncher-8.2-openjdk21.patch | 44 ++++++ .../prismlauncher/prismlauncher-8.2.ebuild | 166 +++++++++++++++++++++ .../prismlauncher/prismlauncher-9999.ebuild | 18 ++- 4 files changed, 227 insertions(+), 2 deletions(-) (In reply to Larry the Git Cow from comment #13) > The bug has been referenced in the following commit(s): > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=2dad9dd76c2380c45c168a447a1742240d46e1dd > > commit 2dad9dd76c2380c45c168a447a1742240d46e1dd > Author: Andrew Ammerlaan <andrewammerlaan@gentoo.org> > AuthorDate: 2024-03-11 21:23:01 +0000 > Commit: Andrew Ammerlaan <andrewammerlaan@gentoo.org> > CommitDate: 2024-03-11 21:24:38 +0000 > > games-action/prismlauncher: add 8.2 > > Bug: https://bugs.gentoo.org/917072 > Bug: https://bugs.gentoo.org/873142 > Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org> > > games-action/prismlauncher/Manifest | 1 + > .../files/prismlauncher-8.2-openjdk21.patch | 44 ++++++ > .../prismlauncher/prismlauncher-8.2.ebuild | 166 > +++++++++++++++++++++ > .../prismlauncher/prismlauncher-9999.ebuild | 18 ++- > 4 files changed, 227 insertions(+), 2 deletions(-) broke the live ebuild as there is no patch for it The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f1ae9c8fa91716a9b6ca9a98f8aaa93e829dcf2 commit 8f1ae9c8fa91716a9b6ca9a98f8aaa93e829dcf2 Author: Andrew Ammerlaan <andrewammerlaan@gentoo.org> AuthorDate: 2024-03-14 19:34:17 +0000 Commit: Andrew Ammerlaan <andrewammerlaan@gentoo.org> CommitDate: 2024-03-14 19:34:23 +0000 games-action/prismlauncher: fix live Bug: https://bugs.gentoo.org/917072 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org> games-action/prismlauncher/prismlauncher-9999.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e414156f2d87fb457934067d86dcd035fc9ffa39 commit e414156f2d87fb457934067d86dcd035fc9ffa39 Author: Volkmar W. Pogatzki <gentoo@pogatzki.net> AuthorDate: 2024-04-11 09:07:18 +0000 Commit: Andrew Ammerlaan <andrewammerlaan@gentoo.org> CommitDate: 2024-04-11 09:13:46 +0000 games-action/prismlauncher: drop 7.2-r1, 8.0 Closes: https://bugs.gentoo.org/917072 Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net> Closes: https://github.com/gentoo/gentoo/pull/36212 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org> games-action/prismlauncher/Manifest | 2 - .../prismlauncher/prismlauncher-7.2-r1.ebuild | 152 --------------------- .../prismlauncher/prismlauncher-8.0.ebuild | 152 --------------------- 3 files changed, 306 deletions(-) |