Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 917059

Summary: dev-ruby/activesupport: ~alpha keywording request
Product: Gentoo Linux Reporter: matoro <matoro_gentoo>
Component: KeywordingAssignee: Gentoo Ruby Team <ruby>
Status: RESOLVED FIXED    
Severity: enhancement CC: matoro_gentoo
Priority: Normal Keywords: CC-ARCHES, KEYWORDREQ, PullRequest
Version: unspecifiedFlags: nattka: sanity-check+
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/34014
Whiteboard:
Package list:
dev-ruby/activesupport ~alpha dev-ruby/connection_pool ~alpha dev-ruby/dalli ~alpha dev-ruby/i18n ~alpha dev-ruby/listen ~alpha dev-ruby/tzinfo ~alpha dev-ruby/mocha ~alpha dev-ruby/rb-inotify ~alpha dev-ruby/test_declarative ~alpha dev-ruby/thor ~alpha dev-ruby/childlabor ~alpha dev-ruby/ffi ~alpha dev-ruby/ruby2_keywords ~alpha dev-ruby/webmock ~alpha dev-ruby/addressable ~alpha dev-ruby/crack ~alpha dev-ruby/hashdiff ~alpha dev-ruby/rspec-retry ~alpha dev-ruby/public_suffix ~alpha dev-ruby/rspec-its ~alpha
Runtime testing required: ---
Bug Depends on: 912063, 917362, 917648, 917654    
Bug Blocks: 873523    

Description matoro archtester 2023-11-09 01:30:02 UTC
Thanks
Comment 1 Larry the Git Cow gentoo-dev 2023-11-12 04:42:45 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b078a1510c27dc875c64f4805a9cf5b24e49ab0e

commit b078a1510c27dc875c64f4805a9cf5b24e49ab0e
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2023-11-11 06:40:56 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-12 04:41:42 +0000

    dev-ruby/dalli: add test dep on dev-ruby/rack-session
    
    Bug: https://bugs.gentoo.org/917059
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-ruby/dalli/dalli-3.2.6.ebuild | 1 +
 1 file changed, 1 insertion(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6181afd114629b45e4325eb8e7247992e234e75a

commit 6181afd114629b45e4325eb8e7247992e234e75a
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2023-11-11 04:32:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-12 04:41:42 +0000

    dev-ruby/test_declarative: fix tests with minitest 5
    
    See: https://github.com/svenfuchs/test_declarative/pull/24
    Closes: https://bugs.gentoo.org/912063
    Bug: https://bugs.gentoo.org/917059
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../test_declarative-0.0.6-backport-pr24.patch     | 29 ++++++++++++++++++++++
 .../test_declarative-0.0.6-r1.ebuild               |  1 +
 2 files changed, 30 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2023-12-01 08:56:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e8b923873f59e591fefe8a798cf4bf3e2d2fb71

commit 7e8b923873f59e591fefe8a798cf4bf3e2d2fb71
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2023-11-26 03:20:04 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2023-12-01 08:52:52 +0000

    dev-ruby/activesupport: add msgpack dep; fix tests
    
    See: https://blog.saeloun.com/2023/11/15/rails-7-1-message-pack-as-message-serializer/
    Bug: https://bugs.gentoo.org/917059
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Signed-off-by: Hans de Graaff <graaff@gentoo.org>

 .../activesupport/activesupport-7.1.1-r1.ebuild    | 82 ++++++++++++++++++++++
 .../activesupport-7.1.1-backport-pr50097.patch     | 65 +++++++++++++++++
 dev-ruby/activesupport/metadata.xml                |  3 +
 3 files changed, 150 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2023-12-01 09:15:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74f6ec05976907422de16683c6212223986e4cfc

commit 74f6ec05976907422de16683c6212223986e4cfc
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2023-11-26 03:16:13 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2023-12-01 09:15:09 +0000

    profiles/arch/powerpc: mask dev-ruby/activesupport[msgpack,test]
    
    Bug: https://bugs.gentoo.org/917059
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Signed-off-by: Hans de Graaff <graaff@gentoo.org>

 profiles/arch/powerpc/package.use.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 4 Matt Turner gentoo-dev 2023-12-04 21:40:41 UTC
Why do we want this on alpha?
Comment 5 matoro archtester 2023-12-05 03:13:52 UTC
(In reply to Matt Turner from comment #4)
> Why do we want this on alpha?

Pulled in via dev-ruby/timecop keyword.
Comment 6 Matt Turner gentoo-dev 2023-12-05 15:24:46 UTC
(In reply to matoro from comment #5)
> (In reply to Matt Turner from comment #4)
> > Why do we want this on alpha?
> 
> Pulled in via dev-ruby/timecop keyword.

It looks like the only reason timecop is keyworded is for dev-ruby/concurrent-ruby, which has no keyworded reverse dependencies on alpha.

So I don't think any of this is necessary.
Comment 7 matoro archtester 2023-12-05 17:47:00 UTC
(In reply to Matt Turner from comment #6)
> (In reply to matoro from comment #5)
> > (In reply to Matt Turner from comment #4)
> > > Why do we want this on alpha?
> > 
> > Pulled in via dev-ruby/timecop keyword.
> 
> It looks like the only reason timecop is keyworded is for
> dev-ruby/concurrent-ruby, which has no keyworded reverse dependencies on
> alpha.
> 
> So I don't think any of this is necessary.

This is also covering dev-ruby/ruby2_keywords which is pulled in via dev-ruby/drb.  Plus, I've already done all the work now, including discovering a hang on powerpc that I wouldn't have discovered if not for this investigation, check out https://github.com/msgpack/msgpack-ruby/pull/355
Comment 8 Matt Turner gentoo-dev 2023-12-05 18:03:36 UTC
(In reply to matoro from comment #7)
> (In reply to Matt Turner from comment #6)
> > (In reply to matoro from comment #5)
> > > (In reply to Matt Turner from comment #4)
> > > > Why do we want this on alpha?
> > > 
> > > Pulled in via dev-ruby/timecop keyword.
> > 
> > It looks like the only reason timecop is keyworded is for
> > dev-ruby/concurrent-ruby, which has no keyworded reverse dependencies on
> > alpha.
> > 
> > So I don't think any of this is necessary.
> 
> This is also covering dev-ruby/ruby2_keywords which is pulled in via
> dev-ruby/drb.

But nothing with alpha keywords depends on dev-ruby/drb, right? So just remove that keyword.

>               Plus, I've already done all the work now, including
> discovering a hang on powerpc that I wouldn't have discovered if not for
> this investigation, check out
> https://github.com/msgpack/msgpack-ruby/pull/355

I don't understand how this is relevant?
Comment 9 matoro archtester 2023-12-05 18:55:07 UTC
alpha done

all arches done