Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 916204

Summary: app-editors/emacs-29.1.9999: USE="svg imagemagick" should pull in media-gfx/imagemagick[svg]
Product: Gentoo Linux Reporter: Pascal Jäger <pascal.jaeger>
Component: Current packagesAssignee: GNU Emacs project <gnu-emacs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Pascal Jäger 2023-10-24 06:54:01 UTC
When emacs is compiled with USE=svg and USE=imagemagick and imagemagick is compiled with USE="-svg" it still wont display svg images and will display 'imagemagick error' in the messages buffer. 

When imagemagick is compiled with USE=svg svg-images are displayed properly in emacs. 

I think when emacs is compiled with svg support and imagemagick support it should depend on the svg USE-flag of imagemagick. 

Same goes for the jpeg and png I guess, but I haven't tested.
Comment 1 Larry the Git Cow gentoo-dev 2023-10-24 16:38:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a370d9e0cf9af3561db6ae100ffffb5713172329

commit a370d9e0cf9af3561db6ae100ffffb5713172329
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-10-24 16:20:36 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-10-24 16:37:51 +0000

    app-editors/emacs: Add use-dependency on imagemagick
    
    Propagate the flags for the jpeg, png, svg and tiff backends. Otherwise,
    when visiting an image file, the following error will occur for svg:
    
    ImageMagick error: Document is empty
     `No such file or directory` @ error/svg.c/SVGError/3370
    
    For jpeg, png and TIFF, a different error message is printed:
    
    ImageMagick error: no decode delegate for this image format `PNG' @ error/constitute.c/ReadImage/746 [8 times]
    
    No error occurs for webp.
    
    Bug: https://bugs.gentoo.org/916204
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-editors/emacs/emacs-29.1-r5.ebuild   | 577 +++++++++++++++++++++++++++++++
 app-editors/emacs/emacs-29.1.90.ebuild   |   2 +-
 app-editors/emacs/emacs-29.1.9999.ebuild |   2 +-
 app-editors/emacs/emacs-30.0.9999.ebuild |   2 +-
 4 files changed, 580 insertions(+), 3 deletions(-)
Comment 2 Ulrich Müller gentoo-dev 2023-10-24 16:41:46 UTC
Same problem for the jpeg, png and tiff backends.

I've committed a fix for slots 29, 29-vcs and 30-vcs. Leaving this bug open: when there are no new issues introduced by this, I'll backport it to stable.
Comment 3 Larry the Git Cow gentoo-dev 2023-11-09 10:51:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2dfc764a6cad6e9553c15bcb8ea79e1346dffeb4

commit 2dfc764a6cad6e9553c15bcb8ea79e1346dffeb4
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-11-09 10:48:12 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-11-09 10:48:12 +0000

    app-editors/emacs: Update imagemagick dependency for remaining slots
    
    Closes: https://bugs.gentoo.org/916204
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-editors/emacs/{emacs-25.3-r18.ebuild => emacs-25.3-r19.ebuild} | 2 +-
 app-editors/emacs/{emacs-26.3-r15.ebuild => emacs-26.3-r16.ebuild} | 2 +-
 app-editors/emacs/{emacs-27.2-r13.ebuild => emacs-27.2-r14.ebuild} | 2 +-
 app-editors/emacs/{emacs-28.2-r9.ebuild => emacs-28.2-r10.ebuild}  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)