Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 915572

Summary: [guru] app-editors/imhex-1.31.0 adds -Werror flag on its own
Product: GURU Reporter: Agostino Sarubbo <ago>
Component: Package issuesAssignee: Gasc Henri <gasc>
Status: RESOLVED FIXED    
Severity: normal CC: esigra, guru-bugs
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 260867    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2023-10-11 06:43:56 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-editors/imhex-1.31.0 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-10-11 06:43:58 UTC
Created attachment 872526 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2023-10-12 03:41:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=4ff61553ace74522dfed1aa0bb812a440e922676

commit 4ff61553ace74522dfed1aa0bb812a440e922676
Author:     Henri Gasc <gasc@eurecom.fr>
AuthorDate: 2023-10-11 08:24:36 +0000
Commit:     Henri Gasc <gasc@eurecom.fr>
CommitDate: 2023-10-11 08:25:20 +0000

    app-editors/imhex: add patches
    
    Closes: https://bugs.gentoo.org/915572
    Signed-off-by: Henri Gasc <gasc@eurecom.fr>

 app-editors/imhex/files/remove-Werror.patch        | 44 ++++++++++++++++++++++
 .../files/{llvm-16.patch => require-llvm-16.patch} |  8 +++-
 app-editors/imhex/imhex-1.31.0.ebuild              |  3 +-
 3 files changed, 52 insertions(+), 3 deletions(-)