Bug 915316 – media-libs/giflib: Missing large file support

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Allen Webb 2023-10-06 16:56:34 UTC]

media-libs/giflib is missing large file support:

```
11:54:23.445  * QA Notice: The following files were not built with LFS support:
11:54:23.459  *   Please see https://issuetracker.google.com/201531268 for details.
11:54:23.476  * fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/bin/gif2rgb
11:54:23.480  * __open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/bin/giffix
11:54:23.484  * fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/bin/gifbuild
11:54:23.488  * fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/bin/gifclrmp
11:54:23.492  * __open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/bin/giftext
11:54:23.496  * __open_2,open /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/lib/libgif.so.7.2.0
11:54:23.500  * fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/lib/debug/usr/bin/gif2rgb.debug
11:54:23.504  * __open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/lib/debug/usr/bin/giftext.debug
11:54:23.508  * fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/lib/debug/usr/bin/gifclrmp.debug
11:54:23.511  * fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/lib/debug/usr/bin/gifbuild.debug
11:54:23.515  * __open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/lib/debug/usr/bin/giffix.debug
11:54:23.519  * __open_2,open /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/image/usr/lib/debug/usr/lib/libgif.so.7.2.0.debug
11:54:23.534  * Full build files:
fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/gif2rgb
__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/giffix
mkstemp /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/gifinto
__open_2,open /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/libgif.so
open /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/egif_lib.o
fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/gifbuild
__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/gifhisto
fopen,__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/gifclrmp
__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/dgif_lib.o
__open_2 /build/arm-generic/tmp/portage/media-libs/giflib-5.2.1-r1/work/giflib-5.2.1-.arm/giftext
```

Using append-lfs-flags from flag-o-matic resolves the issue for me. I confirmed there do not appear to be cases of off_t or dirent in the APIs.

Reproducible: Always

[Comment 1 Larry the Git Cow 2024-05-30 03:54:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=033629cddfc22d7bcead70daa7b6eaa76f0bc623

commit 033629cddfc22d7bcead70daa7b6eaa76f0bc623
Author:     Sam James <[e-mail]>
AuthorDate: 2024-05-30 03:50:58 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-30 03:53:53 +0000

    media-libs/giflib: add 5.2.2
    
    The release notes mention CVE-2023-48161 and CVE-2022-28506 by CVE but
    there's a bunch of other security fixes in the list of fixes.
    
    The documentation in this release also adds:
    """
    +<refsect1><title>Bugs</title>
    +
    +<para>Feeding this utility a GIF with an invalid colormap, or other
    +kinds of malformations, index will produce invalid output and may
    +core-dump the tool. Don't do that.</para>
    +
    +</refsect1>
    """
    
    Anyway, on the ebuild side:
    * Replace Makefile patch for doc building conditionally with a sed
    * Make tests more verbose (needed it when debugging bug #848807)
    * Cleanup reallocarray hack (bug #677956)
    * Add LFS support (bug #915316)
    
    Bug: https://bugs.gentoo.org/677956
    Bug: https://bugs.gentoo.org/785664
    Bug: https://bugs.gentoo.org/851945
    Bug: https://bugs.gentoo.org/918539
    Closes: https://bugs.gentoo.org/848807
    Closes: https://bugs.gentoo.org/915316
    Signed-off-by: Sam James <[e-mail]>

 media-libs/giflib/Manifest                         |  1 +
 media-libs/giflib/files/giflib-5.2.2-fortify.patch | 27 ++++++++
 .../giflib/files/giflib-5.2.2-verbose-tests.patch  | 74 +++++++++++++++++++++
 media-libs/giflib/giflib-5.2.2.ebuild              | 76 ++++++++++++++++++++++
 4 files changed, 178 insertions(+)