Summary: | www-client/firefox: fails to build with Rust 1.73 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sam James <sam> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | Adrian.Bassett, arve.barsnes, atoth, chutzpah, herrtimson, leonchik1976 |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=915381 https://bugs.gentoo.org/show_bug.cgi?id=916304 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log.xz
0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch 0002-Bug-1851530-Use-plain-packed_simd.-r-hsivonen-supply.patch |
Description
Sam James
![]() ![]() ![]() ![]() Created attachment 872224 [details]
build.log.xz
Created attachment 872225 [details, diff]
0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch
These patches from upstream wfm.
Created attachment 872226 [details]
0002-Bug-1851530-Use-plain-packed_simd.-r-hsivonen-supply.patch
(Links are at the top of the patches.)
(In reply to Sam James from comment #2) > Created attachment 872225 [details, diff] [details, diff] > 0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch > > These patches from upstream wfm. exherbo seems to have just done this one: https://gitlab.exherbo.org/exherbo/desktop/-/commit/09ca9db3248618ebeba0956a864f9ff88110cdb9#df83cff919759eb53e829e0f138e46a54f9c8232 Firefox (www-client/firefox-118.0.1) builds fine with dev-lang/rust-1.72.0-r1 from FireBurn overlay, compiled with LLVM/Clang 17 as of October 4th, 2023, with no additional patches applied. It fails with dev-lang/rust1.73.0::gentoo, with the following error message: ERROR: Don't know how to translate x86_64-gentoo-linux-musl for rustc (In reply to asdfg from comment #5) > Firefox (www-client/firefox-118.0.1) builds fine with > dev-lang/rust-1.72.0-r1 from FireBurn overlay, compiled with LLVM/Clang 17 > as of October 4th, 2023, with no additional patches applied. > I've no idea what changes that overlay makes, but we have a long-standing reason for using a matching LLVM with the version in the Rust used to build. > It fails with dev-lang/rust1.73.0::gentoo, with the following error message: > > ERROR: Don't know how to translate x86_64-gentoo-linux-musl for rustc That sounds separate. An easy workaround for this is to comment out the --enable-rust-simd part from the firefox (and spidermonkey) ebuilds. >0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch >These patches from upstream wfm. This is not only a LLVM problem, rust 1.73 upgrade on the weekend causes firefox build failure with GCC. I downgraded to rust 1.72 to get a working browser... https://github.com/rust-lang/packed_simd/issues/356#issuecomment-1667769025 It also hits www-client/seamonkey. If I unpack current rust-1.73.0 it has packed_simd_2 0.3.8, not packed_simd 0.3.9. And where to look for rust-brotli's enc directory? What would be the best solution here? *** Bug 915593 has been marked as a duplicate of this bug. *** I think there's still another bug here because nobody should be hitting this. I think it's the fact that rust isn't slotted but the rust/rust-bin situation allows the wrong one to be picked. But w/e. (In reply to Sam James from comment #11) > I think there's still another bug here because nobody should be hitting > this. I think it's the fact that rust isn't slotted but the rust/rust-bin > situation allows the wrong one to be picked. But w/e. virtual/rust-1.72.0-r1 pulls in dev-lang/rust-1.72.0-r1. Upgrading world somehow doesn't upgrade virtual/rust to the latest 1.73.0, therefore there is a discrepancy between rust-bin and rust versions. Explicitly upgrading virtual/rust makes rust-bin bumped to 1.73.0. (In reply to Attila Tóth from comment #12) > (In reply to Sam James from comment #11) > > I think there's still another bug here because nobody should be hitting > > this. I think it's the fact that rust isn't slotted but the rust/rust-bin > > situation allows the wrong one to be picked. But w/e. > > virtual/rust-1.72.0-r1 pulls in dev-lang/rust-1.72.0-r1. Upgrading world > somehow doesn't upgrade virtual/rust to the latest 1.73.0, therefore there > is a discrepancy between rust-bin and rust versions. Explicitly upgrading > virtual/rust makes rust-bin bumped to 1.73.0. Thunderbird and seamonkey pulls in virtual/rust-1.72.0... (In reply to Sam James from comment #11) > I think it's the fact that rust isn't slotted but the rust/rust-bin > situation allows the wrong one to be picked. Maybe rust and rust-bin should block each other so that you don't end up with 2 different subslots of (effectively) the same package. (In reply to Sam James from comment #11) > I think there's still another bug here because nobody should be hitting > this. I think it's the fact that rust isn't slotted but the rust/rust-bin > situation allows the wrong one to be picked. But w/e. Sorry, while this is an issue, I was completely wrong here. This is indeed simply "fails to build with Rust 1.73". I forgot that we only require matching LLVM for Mozilla stuff with USE=clang. (In reply to cyrillic from comment #14) > (In reply to Sam James from comment #11) > > I think it's the fact that rust isn't slotted but the rust/rust-bin > > situation allows the wrong one to be picked. > > Maybe rust and rust-bin should block each other so that you don't end up > with 2 different subslots of (effectively) the same package. That would create and unresolvable conflict in case multiple packages are installed wanting to pull in different slots. It would be better to synchronize firefox, thunderbird and seamonkey regarding the required clang/llvm version if it may even be possible... Temporary downgrading to rust-1.72 solved the problem. (In reply to Attila Tóth from comment #16) > (In reply to cyrillic from comment #14) > > (In reply to Sam James from comment #11) > > > I think it's the fact that rust isn't slotted but the rust/rust-bin > > > situation allows the wrong one to be picked. > > > > Maybe rust and rust-bin should block each other so that you don't end up > > with 2 different subslots of (effectively) the same package. > > That would create and unresolvable conflict in case multiple packages are > installed wanting to pull in different slots. It would be better to > synchronize firefox, thunderbird and seamonkey regarding the required > clang/llvm version if it may even be possible... Thank you for the patches, that will probably do it. I'll try to give it a spin. (In reply to Attila Tóth from comment #18) > > Thank you for the patches, that will probably do it. I'll try to give it a > spin. Wait for 118.0.2, it's looking fine so far so most likely will push it in an hour or two. It as llvm-17 and therefore rust-1.73 support. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=673ff5ed9ae5da6c5fd58bf9c0b2fe2c138742a8 commit 673ff5ed9ae5da6c5fd58bf9c0b2fe2c138742a8 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2023-10-12 10:38:36 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-10-12 10:39:58 +0000 www-client/firefox: add 118.0.2 - llvm-17 and rust-1.73 compatibility, - make 'hardened' use _FORTIFY_SOURCE=3. Closes: https://bugs.gentoo.org/910071 Closes: https://bugs.gentoo.org/915306 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 101 ++ www-client/firefox/firefox-118.0.2.ebuild | 1440 +++++++++++++++++++++++++++++ 2 files changed, 1541 insertions(+) =www-client/firefox-118.0.2 seems to still have the same problem, and those two patches attached fail. (In reply to Morton Pellung from comment #8) > This is not only a LLVM problem, rust 1.73 upgrade on the weekend causes > firefox build failure with GCC. I downgraded to rust 1.72 to get a working > browser... Firefox 118.0.2 builds now fine with "-clang" and rust 1.73.0, tried it on two different machines. Thank you for the fix! (In reply to Morton Pellung from comment #22) > Firefox 118.0.2 builds now fine with "-clang" and rust 1.73.0 ... firefox-118.0.2 also builds fine with USE="clang" when 1.73 is the only rust version installed. |