Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 915133

Summary: app-cdr/cdrdao-1.2.5: access violation on read-toc before TOC files is written
Product: Gentoo Linux Reporter: Florian E. Teply <onlinefloh>
Component: Current packagesAssignee: Martin Dummer <martin.dummer>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/cdrdao/cdrdao/issues/22
https://github.com/cdrdao/cdrdao/pull/21
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 920103    
Bug Blocks:    

Description Florian E. Teply 2023-10-03 19:53:28 UTC
cdrdao-1.2.5 is throwing an access violation on subcommand read-toc after the list of tracks is output, but before trying to read subcode data and writing the TOC file. This in turn breaks cd ripping using whipper. cdrdao-1.2.4-r2 reads the toc just fine.

Reproducible: Always

Steps to Reproduce:
1. insert audio cd into optical drive
2. cdrdao read-toc $TOCFILE
3. 
Actual Results:  
Track list output, afterwards Access violation, no subcode read, no TOC file written

Expected Results:  
Successful extraction of TOC file committed to disk
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-03 19:56:04 UTC
Could you try https://github.com/cdrdao/cdrdao/pull/21.patch?
Comment 2 Florian E. Teply 2023-10-04 19:42:45 UTC
Yeah, just tried the patch and it indeed seems to fix the problem. Didn't run extensive tests though.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-04 19:48:39 UTC
Thanks!
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-16 09:49:25 UTC
martin, still with us..?

anyway, I'll backport it, thanks
Comment 5 Larry the Git Cow gentoo-dev 2023-12-16 09:54:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9297c393d4ed94fde28c97068514bc991f961529

commit 9297c393d4ed94fde28c97068514bc991f961529
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-16 09:52:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-16 09:53:38 +0000

    app-cdr/cdrdao: fix use of uninit. var
    
    Closes: https://bugs.gentoo.org/915133
    Signed-off-by: Sam James <sam@gentoo.org>

 app-cdr/cdrdao/cdrdao-1.2.5-r1.ebuild              | 55 ++++++++++++++++++++++
 app-cdr/cdrdao/files/cdrdao-1.2.5-fix-uninit.patch | 27 +++++++++++
 2 files changed, 82 insertions(+)