Bug 915020

Summary:	media-sound/strawberry-1.0.20-r1 player controls, seekbar broken
Product:	Gentoo Linux	Reporter:	Uros <infinity80>
Component:	Current packages	Assignee:	Gentoo Sound Team <sound>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fordfrog, infinity80, jjm, qt
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	AMD64
OS:	Linux
See Also:	https://github.com/strawberrymusicplayer/strawberry/issues/1283
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	912819
Attachments:	Patch to fix player controls

Description Uros 2023-10-01 14:05:06 UTC

I've upgraded to media-sound/strawberry-v1.0.18 a while back and encountered broken player controls / seekbar. I've downgraded back to v1.0.17 and everything was back to normal.

Today, I've upgraded to v1.0.20-r1 only to encounter same issue as in v1.0.18, but now v1.0.17 is not in the tree anymore.

I've submitted upstream report (https://github.com/strawberrymusicplayer/strawberry/issues/1283).

According to response (https://github.com/strawberrymusicplayer/strawberry/issues/1283#issuecomment-1742060280), issue might be with "... some change in Qt that broke binary compatibility, or some patch applied to Qt that broke it."

Not sure on how to proceed or if it's related to media-sound/strawberry, dev-qt/qtcore or something else.

Reproducible: Always

Steps to Reproduce:
1. Install media-sound/strawberry-1.0.20-r1
2. Open player
3. Start playing track
Actual Results:  
Player controls are broken

Expected Results:  
Player controls should not be broken

When trying to rebuild media-sound/strawberry-v1.0.17 (https://gitweb.gentoo.org/repo/gentoo.git/plain/media-sound/strawberry/strawberry-1.0.17.ebuild?id=a43f6105c927ba1a6b622f8702df475ab17e450b) with dev-libs/protobuf-23.3-r2, build fails at ..

[946/959] : && /usr/bin/x86_64-pc-linux-gnu-g++ -march=core2 -O2 -pipe -Wl,-O1 -Wl,--as-needed ext/strawberry-tagreader/CMakeFiles/strawberry-tagreader.dir/main.cpp.o ext/strawberry-tagreader/CMakeFiles/strawberry-tagreader.dir/tagreaderworker.cpp.o ext/strawberry-tagreader/CMakeFiles/strawberry-tagreader.dir/moc_tagreaderworker.cpp.o -o strawberry-tagreader  -lglib-2.0  ext/libst
rawberry-common/liblibstrawberry-common.a  ext/libstrawberry-tagreader/liblibstrawberry-tagreader.a  -ltag  -lz  ext/libstrawberry-common/liblibstrawberry-common.a  -lglib-2.0  /usr/lib64/libQt5Network.so.5.15.10  /usr/lib64/libprotobuf.so  -ltag  -lz  /usr/lib64/libQt5Gui.so.5.15.10  /usr/lib64/libQt5Core.so.5.15.10 && :
FAILED: strawberry-tagreader
: && /usr/bin/x86_64-pc-linux-gnu-g++ -march=core2 -O2 -pipe -Wl,-O1 -Wl,--as-needed ext/strawberry-tagreader/CMakeFiles/strawberry-tagreader.dir/main.cpp.o ext/strawberry-tagreader/CMakeFiles/strawberry-tagreader.dir/tagreaderworker.cpp.o ext/strawberry-tagreader/CMakeFiles/strawberry-tagreader.dir/moc_tagreaderworker.cpp.o -o strawberry-tagreader  -lglib-2.0  ext/libstrawberry-common/liblibstrawberry-common.a  ext/libstrawberry-tagreader/liblibstrawberry-tagreader.a  -ltag  -lz  ext/libstrawberry-common/liblibstrawberry-common.a  -lglib-2.0  /usr/lib64/libQt5Network.so.5.15.10  /usr/lib64/libprotobuf.so  -ltag  -lz  /usr/lib64/libQt5Gui.so.5.15.10  /usr/lib64/libQt5Core.so.5.15.10 && :
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ext/libstrawberry-tagreader/liblibstrawberry-tagreader.a(tagreadermessages.pb.cc.o): undefined reference to symbol '_ZN4absl12lts_2023080212log_internal17MakeCheckOpStringIllEEPNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_T0_PKc'
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib64/libabsl_log_internal_check_op.so.2308.0.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

Downgrading to dev-libs/protobuf-21.12 and rebuilding works again and player behaves as it should.

Comment 1 Miroslav Šulc gentoo-dev

2024-01-10 09:33:48 UTC

what's the current status?

Comment 2 Uros 2024-01-10 10:24:51 UTC

I'm still running media-sound/strawberry-v1.0.17, since I wasn't able to make v1.0.18+ work without "player control issues" as mentioned above.

I can see that v1.0.21 and v1.0.22 are already in tree (have it masked, didn't notice upgrades).

Will find some time later this week and try upgrading to v1.0.22, then report back.

Comment 3 Uros 2024-01-14 22:08:20 UTC

Upgraded to media-sound/strawberry-1.0.23, issue is still present.

Related log lines, from verbose strawberry output, according to upstream:
22:51:52.451 WARN  unknown  QObject::connect: Cannot queue arguments of type 'State' 
22:51:52.451 WARN  unknown  (Make sure 'State' is registered using qRegisterMetaType().)

Comment 4 Jonathan Marten 2024-05-17 17:38:59 UTC

Created attachment 893156 [details, diff]
Patch to fix player controls

This patch appears to fix the problem for me with media-sound/strawberry-1.0.23, VLC backend, dev-qt/*-5.15.13.  With it applied, the player controls and the progress bar appear to operate correctly - except that the "Pause" button does not change back to "Play" after a "Stop", this may be a separate bug.  The error messages as described in comment #3 and the upstream bug do not appear.

Comment 5 Andreas Sturmlechner gentoo-dev

2024-05-30 09:48:23 UTC

Could you try and submit your patch upstream, please?

Comment 6 Jonathan Marten 2024-05-30 20:21:24 UTC

Submitted upstream as
https://github.com/strawberrymusicplayer/strawberry/issues/1450

Comment 7 Uros 2024-06-12 13:13:38 UTC

I've added patch mentioned in comment #4 and upgraded to media-sound/strawberry-1.0.23-r1.

Everything works as expected now.

Patch was already commited upstream - https://github.com/strawberrymusicplayer/strawberry/commit/d7cc52bc99e38f85f37431ab70895308042e21df

This can be closed.