| Summary: | dev-libs/libpeas-2.0.0 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Blake Batson <bbatson101> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | UNCONFIRMED --- | ||
| Severity: | normal | Keywords: | EBUILD |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 914751 | ||
| Attachments: |
updated libpeas ebuild
Rebased gentoo-lua patch for 2.0.0 libpeas 2.0.0 version bump and patch rebase libpeas reverse dependencies dev-libs/libpeas-2.0.0 version bump, patch rebase, and reverse dependency bump from slot addition |
||
Created attachment 871486 [details, diff]
Rebased gentoo-lua patch for 2.0.0
Could you attach patches in the form of 'git format-patch' output with a Signed-off-by instead? It's a lot easier to review and apply then. Thanks! Created attachment 871495 [details, diff]
libpeas 2.0.0 version bump and patch rebase
Sure, I think this is right
Thanks! I've also noticed there's https://github.com/gentoo/gentoo/pull/32202 (which appears stalled) for libpeas/gnome-builder. Maybe double check if any of the comments there apply to yours? Created attachment 871497 [details]
libpeas reverse dependencies
Looking at that PR the only thing that jumps out at me in regards to libpeas specifically is that I missed a dependency on spidermonkey-115. It got pulled in anyways because the only packaged gjs version that met the version requirements depended on it as well. Should I add that to the dependencies just to be safe?
Also it was mentioned that the reverse dependencies of libpeas should be updated to specify a slot. I got a list of them from equery (attached), should I specify the libpeas slot those ebuilds depend on and include them in this patch?
Yeah, if libpeas is gaining a new slot, all existing reverse dependencies must specify which they need (with a revbump, but can git mv for this). Created attachment 871498 [details, diff]
dev-libs/libpeas-2.0.0 version bump, patch rebase, and reverse dependency bump from slot addition
Alright I updated the dependencies with new revisions that specify the slot
|
Created attachment 871485 [details] updated libpeas ebuild Needed to bump this for dev-util/gnome-builder-45. I'm pretty sure it should go into a new slot which is what I did in the attached ebuild. I had to update the lua patch too.