Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 914590

Summary: Query Functions Reference doesn't mention EAPI 8 variant of usev
Product: Documentation Reporter: Sam James <sam>
Component: DevmanualAssignee: Gentoo Devmanual Team <devmanual>
Status: RESOLVED FIXED    
Severity: normal CC: eschwartz
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://devmanual.gentoo.org/function-reference/query-functions/index.html
See Also: https://bugs.gentoo.org/show_bug.cgi?id=914613
https://github.com/gentoo/devmanual/pull/313
https://bugs.gentoo.org/show_bug.cgi?id=916017
Whiteboard:
Package list:
Runtime testing required: ---

Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-24 06:52:06 UTC
https://devmanual.gentoo.org/function-reference/query-functions/index.html doesn't mention the improvements in EAPI 8 for usev (bug 744868).

Need to check while there if there's any other EAPI changes we need to reference on the page.

(Noticed b/c of https://github.com/gentoo/gentoo/pull/32989#discussion_r1335105634)
Comment 1 Ulrich Müller gentoo-dev 2023-09-24 07:45:04 UTC
usev with two arguments is mentioned here:
https://devmanual.gentoo.org/ebuild-writing/eapi/index.html#eapi-8-commands

This is not an isolated problem. All items listed in the EAPI chapter need to be checked and integrated with the relevant sections. Looks like the last such systematic overhaul was done in 2020, for EAPI 4:
https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=3b8fa72d91bbdd08aa08f7e7bf0ca66833095186
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-27 01:56:59 UTC
Another example: dosym -r.

But yes, we need to do a full audit :(
Comment 3 Ulrich Müller gentoo-dev 2023-09-27 19:29:36 UTC
This doesn't stop us from doing single improvements.

How about the following wording?

  <tr>
    <ti>
      <c>usev flagname [true output]</c>
    </ti>
    <ti>
      As <c>use</c>. Upon success, echoes either <c>[true output]</c>, or
      <c>flagname</c> if called with only one argument.
    </ti>
  </tr>
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-28 04:58:21 UTC
"if called with only one argument (for EAPI 8+)." ?
Comment 5 Larry the Git Cow gentoo-dev 2023-10-05 18:58:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=546b966a7f10773de891ab4e280e3aefe0c142c0

commit 546b966a7f10773de891ab4e280e3aefe0c142c0
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-10-01 17:29:06 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-10-01 17:29:06 +0000

    function-reference/query-functions: usev accepts two args in EAPI 8
    
    Closes: https://bugs.gentoo.org/914590
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 function-reference/query-functions/text.xml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)