| Summary: | Kopete crashes when opening a new window after closing tab | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Nathan Toone <nathan> |
| Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
kdenetwork-3.4.0-kopete-tabbed-windows.patch
kopete-3.4.0-r1.ebuild |
||
|
Description
Nathan Toone
2005-05-04 06:14:04 UTC
Sorry - I meant to look up the bug number for the KDE bug, but I sent before I did it... It's http://bugs.kde.org/show_bug.cgi?id=101008 The main suspect here is kdenetwork-3.4.0-kopete-logout.patch, for http://bugs.kde.org/show_bug.cgi?id=91288. If you can confirm that it is the culprit, please inform kde developers, because that patch will be in kde-3.4.1. I can confirm this - removing the patch for kopete-logout fixed the issue 100%. The change (removal of this patch) should probably be made in portage until a new patch which works can be put in. > The change (removal of this patch) should probably be made in portage until a new patch which works can be put in.
This would exchange a crash for another one... we can only wait for a proper fix from the kde side, I guess.
My arguments for removing the patch: (take them as you will...) 1 - the version of kde that we are running is 3.4.0 - so if we have a crash that is known in 3.4.0, it's not a big deal (that is, most other distros have the 3.4.0 crash) 2 - the crash that the patch fixes only happens on KDE shutdown - the crash that the patch creates happens multiple times *DURING* normal use of kopete. Again - take them as you will...I can always just keep my own copy of the ebuild in my overlay directory...it just seems to make more sense (to me, anyway) to remove it from portage as well. And then there's the even better option! How about fix the bug??? :) This bug (the tabbed window crash) is logged as kde bug 105442. There is a patch for it at http://lists.kde.org/?l=kde-cvs&m=111115078602663&w=2 I have modified my ebuild to include this patch - I will post both the ebuild and the patch. One thing to note - this patch needs to be applied *after* the first patch (the logout patch) since it's that patch that causes this bug. Another option would be to modify the logout patch to include the fixes in the tabbed-windows patch. (as you can see in the tabbed-windows patch, the problem is a block that is commented out that should not be.) This fixes both problems - the logout crash and the tabbed windows crash. Can we include THIS in portage? Created attachment 58671 [details, diff]
kdenetwork-3.4.0-kopete-tabbed-windows.patch
Patch to fix crash
Created attachment 58672 [details]
kopete-3.4.0-r1.ebuild
My ebuild with the patch integrated
Surely this is the best solution :) Committed as kdenetwork-3.4.0-r2/kopete-3.4.0-r2 I don't know (because I don't run it), but the kdenetwork package may suffer from the same problem if it also uses the same logout patch (which it appears it does...) >Committed as kdenetwork-3.4.0-r2/kopete-3.4.0-r2
OK - so I need to read more carefully... :0
|
