Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 914202

Summary: media-gfx/krita: Tablet pen is incorrectly offset when using non-default QT_SCALE_FACTOR (was: dev-qt/qtgui-5.15.10-r1: highdpi offset of QTabletEvent coordinates on xcb)
Product: Gentoo Linux Reporter: Elliott Lester <lester.elliott>
Component: Current packagesAssignee: Gentoo KDE team <kde>
Status: RESOLVED UPSTREAM    
Severity: normal CC: qt
Priority: Normal Keywords: PATCH, UPSTREAM
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://bugs.kde.org/show_bug.cgi?id=464256
See Also: https://invent.kde.org/qt/qt/qtbase/-/merge_requests/257
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 913934    

Description Elliott Lester 2023-09-15 00:42:02 UTC
Tablet pen is incorrectly offset when using non-default QT_SCALE_FACTOR in recent builds

Please add this patch to the gentoo-patchset 
https://invent.kde.org/szaman/qtbase/-/commit/e075c06efbc1b61bb5e4daec895936530f158ddb

Reproducible: Always

Steps to Reproduce:
1. Use graphics tablet with X11 application
2.
3.
Actual Results:  
all sub windows (menus, combo boxes) have the wrong cursor position

Expected Results:  
tablet works as expected

https://invent.kde.org/szaman/qtbase/-/commit/e075c06efbc1b61bb5e4daec895936530f158ddb
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-15 00:44:35 UTC
Has this been submitted anywhere? Your link isn't to a MR adding it to Qt5PatchCollection.
Comment 2 Elliott Lester 2023-09-15 00:52:13 UTC
I wasn't sure where to make the MR for the patchset where should it go?
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-15 01:00:54 UTC
No problem - take a look at https://community.kde.org/Qt5PatchCollection#How_do_I_get_a_patch_merged?.

When submitting it, add a comment saying 'cc @asturmlechner @thesamesam' so asturm and I see it.
Comment 4 Elliott Lester 2023-09-15 01:01:39 UTC
Maybe this looks like it got stuck in limbo
https://invent.kde.org/qt/qt/qtbase/-/merge_requests/257
Comment 5 Andreas Sturmlechner gentoo-dev 2023-09-15 18:35:14 UTC
We can't add patches that have been reverted already once for causing issues, and that is the problem in this MR. The krita patch does not seem to be different to the original one, even if it has different authorship.
Comment 6 Elliott Lester 2023-09-15 22:39:53 UTC
The difference is subtle

the original qt6 backport called 

xcbWindow->mapFromGlobalF

which is not available in qt5

this change calls 

xcbWindow->mapFromGlobal

which works 

specifically this patch

https://invent.kde.org/szaman/qtbase/-/commit/e075c06efbc1b61bb5e4daec895936530f158ddb
Comment 7 Andreas Sturmlechner gentoo-dev 2023-09-16 10:53:16 UTC
Thanks for pointing it out. Upstream MR (that I myself created, incidentally) is the correct place for this discussion, anyway. As soon as it is integrated there, it is slated to land in ::gentoo.
Comment 8 Larry the Git Cow gentoo-dev 2023-09-21 19:34:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0f4f761b16e298609bce89e000ea33b3c67487d

commit a0f4f761b16e298609bce89e000ea33b3c67487d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-08-16 18:30:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-21 19:33:51 +0000

    dev-qt/qtgui: Bump to QT5_KDEPATCHSET_REV=3
    
    Eskil Abrahamsen Blomfeldt (1):
          Fix crash when setting override cursor on multiple clients
    
    Marc Mutz (1):
          Fix UB (signed char passed to <cctype> function)
    
    Mike Achtelik (1):
          Android A11Y: Fix deadlock in QtAndroidAccessibility::runInObjectContext()
    
    Mike Krus (1):
          Qt3DRender: includemocs
    
    Shawn Rutledge (1):
          Fix highdpi conversion of QTabletEvent coordinates on xcb
    
    Bug: https://bugs.gentoo.org/914202
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtgui/Manifest                |   1 +
 dev-qt/qtgui/qtgui-5.15.10-r2.ebuild | 178 +++++++++++++++++++++++++++++++++++
 2 files changed, 179 insertions(+)