| Summary: | kde-apps/konsole: missing dependency on kde-frameworks/kglobalaccel | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sam James <sam> |
| Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/kde.git/commit/?id=c533d4ddb542fcb3c71255bc359eb7d0e2afec58 commit c533d4ddb542fcb3c71255bc359eb7d0e2afec58 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2023-09-14 20:56:11 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2023-09-14 21:14:28 +0000 kde-apps/konsole: Add missing dependency Bug: https://bugs.gentoo.org/914127 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> kde-apps/konsole/konsole-23.08.49.9999.ebuild | 3 ++- kde-apps/konsole/konsole-9999.ebuild | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) (In reply to Sam James from comment #0) > x11-libs/libX11 < Not exactly clear how to fix that yet. Upstream usage seems to only remain for detection if we are on X. That may or may not be obsolete by code changes already. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/kde.git/commit/?id=6663a2bf1415d295444b5500d6911ee6e6f15727 commit 6663a2bf1415d295444b5500d6911ee6e6f15727 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2023-09-15 14:25:59 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2023-09-15 14:25:59 +0000 kde-apps/konsole: Drop unused dep, drop IUSE X Closes: https://bugs.gentoo.org/914127 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../konsole-23.08.1-drop-unused-X11-dep.patch | 30 ++++++++++++++++++++++ kde-apps/konsole/konsole-23.08.49.9999.ebuild | 11 ++------ kde-apps/konsole/konsole-9999.ebuild | 11 ++------ 3 files changed, 34 insertions(+), 18 deletions(-) |
``` VDB: detected possibly incorrect RDEPEND (kde-apps/konsole-23.08.0) > kde-frameworks/kglobalaccel:5 x11-libs/libX11 < ``` ``` $ rg globalaccel -i /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0 /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/src/Application.cpp:22:#include <KGlobalAccel> /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/src/Application.cpp:515: KGlobalAccel::self()->setGlobalShortcut(action, QKeySequence(Konsole::ACCEL | Qt::Key_F12)); /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole.upd:3:Id=konsole_globalaccel /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole.upd:5:Script=konsole_globalaccel /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/CMakeLists.txt:1:add_executable(konsole_globalaccel /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/CMakeLists.txt:2: konsole_globalaccel.cpp /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/CMakeLists.txt:5:target_link_libraries(konsole_globalaccel PRIVATE /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/CMakeLists.txt:7: KF${QT_MAJOR_VERSION}::GlobalAccel /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/CMakeLists.txt:25:install(TARGETS konsole_globalaccel konsole_show_menubar DESTINATION ${KDE_INSTALL_LIBDIR}/kconf_update_bin) /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole_globalaccel.cpp:12:#include <KGlobalAccel> /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole_globalaccel.cpp:24: // Tell kglobalaccel that the action is active. /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole_globalaccel.cpp:25: KGlobalAccel::self()->setShortcut(&action, shortcuts); /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole_globalaccel.cpp:27: KGlobalAccel::self()->setShortcut(&action, shortcuts, KGlobalAccel::NoAutoloading); /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole_globalaccel.cpp:56: const QList<QKeySequence> shortcuts = KGlobalAccel::self()->globalShortcut(QStringLiteral("khotkeys"), shortcutId); /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole_globalaccel.cpp:62: KGlobalAccel::self()->setShortcut(&action, {}); /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole_globalaccel.cpp:63: KGlobalAccel::self()->removeAllShortcuts(&action); /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/kconf_update/konsole_globalaccel.cpp:65: // Migrate to kglobalaccel. /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/src/CMakeLists.txt:84: KF${QT_MAJOR_VERSION}::GlobalAccel /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/desktop/CMakeLists.txt:7:install( FILES org.kde.konsole.desktop DESTINATION ${KDE_INSTALL_DATADIR}/kglobalaccel) /var/tmp/portage/kde-apps/konsole-23.08.0/work/konsole-23.08.0/CMakeLists.txt:92: GlobalAccel sam@mop ~/g/kde-apps/konsole $ rg global -i ```