Bug 914004

Summary:	net-im/neochat: Should somehow depend on qtmultimedia[gstreamer]
Product:	Gentoo Linux	Reporter:	gerion <gerion.entrup>
Component:	Current packages	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/33296 https://bugs.gentoo.org/show_bug.cgi?id=918509
Whiteboard:
Package list:		Runtime testing required:	---

Description gerion 2023-09-11 12:47:29 UTC

Neochat is a Matrix client. In the protocol it is possible to send video files.
When Neochat is compiled with dev-qt/qtmultimedia without the use gstreamer, the video is downloaded and a play button is displayed but it is not played.

When dev-qt/qtmultimedia[gstreamer] is installed, the video plays like expected.
For a user this dependency is not obvious. If would be nice if neochat also get an gstreamer or videoplayback useflag or hard depend on that flag.

Reproducible: Always




I have tested this with neochat-23.08.0-r1 and qtmultimedia-5.15.10.

Comment 1 Larry the Git Cow gentoo-dev

2023-11-11 20:11:34 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d227953e46865883294c42b49073077bcccba77a

commit d227953e46865883294c42b49073077bcccba77a
Author:     Gerion Entrup <gerion.entrup@flump.de>
AuthorDate: 2023-10-11 11:06:18 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-11-11 20:09:57 +0000

    net-im/neochat: depend on dev-qt/qtmultimedia[gstreamer]
    
    This enables video playback. It could be a runtime useflag (which,
    however, is currently unsupported). Without gstreamer support, Neochat
    cannot play videos but does not indicate an error in any way, which is
    at best confusing by a user or lead to meaningless bug reports at worst.
    We therefore hard depend on the support.
    
    Closes: https://bugs.gentoo.org/914004
    Signed-off-by: Gerion Entrup <gerion.entrup@flump.de>
    Closes: https://github.com/gentoo/gentoo/pull/33296
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 net-im/neochat/neochat-23.08.3-r1.ebuild | 54 ++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

Comment 2 Larry the Git Cow gentoo-dev

2023-11-11 20:16:58 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=0d8a8e5f740e5021cf80d4fbada4e97bc482de94

commit 0d8a8e5f740e5021cf80d4fbada4e97bc482de94
Author:     Gerion Entrup <gerion.entrup@flump.de>
AuthorDate: 2023-10-11 11:06:18 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-11-11 20:16:06 +0000

    net-im/neochat: depend on dev-qt/qtmultimedia[gstreamer]
    
    This enables video playback. It could be a runtime useflag (which,
    however, is currently unsupported). Without gstreamer support, Neochat
    cannot play videos but does not indicate an error in any way, which is
    at best confusing by a user or lead to meaningless bug reports at worst.
    We therefore hard depend on the support.
    
    Closes: https://bugs.gentoo.org/914004
    Signed-off-by: Gerion Entrup <gerion.entrup@flump.de>
    Closes: https://github.com/gentoo/gentoo/pull/33296
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 net-im/neochat/neochat-23.08.49.9999.ebuild | 2 +-
 net-im/neochat/neochat-9999.ebuild          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)