Bug 913734

Summary:	media-libs/lsp-plugins-9999 fail to compile due to incomplete fetching
Product:	Gentoo Linux	Reporter:	Dominique Michel <dominique.c.michel>
Component:	Current packages	Assignee:	Matthew Thode ( prometheanfire ) <prometheanfire>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	dominique.c.michel
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	working ebuild

Description Dominique Michel 2023-09-06 20:11:53 UTC

Upstream changed the build system and added a "make fetch" between "make config" and "make". It is possible to replace that "make fetch" into a src_unpack phase.

Reproducible: Always

Steps to Reproduce:
1. emerge =media-libs/lsp-plugins-9999
2.
3.
Actual Results:  
Fail to compile because the build system want to fetch code outside of src_unpack.

Comment 1 Dominique Michel 2023-09-06 20:25:32 UTC

Created attachment 869978 [details]
working ebuild

This fix the fetching issue ans add a few other changes:

- DOCS installation.
- html doc location. I didn't figured out how to fix it before pkg_preinst.
- Categories fix into the application desktop files. It is only a X- main category, but according to https://specifications.freedesktop.org/menu-spec/latest/apa.html
"The list of Main Categories consists of those categories that every conforming desktop environment MUST support."
So, also in pkg_preinst, I change the Categories key in these files to
Categories=AudioVideo;Audio;X-LSP-Plugins;
- moved from xdg eclass to xdg-utils.

Comment 2 Dominique Michel 2023-09-06 20:32:56 UTC

Also, I am not sure if media-libs is the right location for lsp-plugins. I think that many users, if not most users, will install it with at least USE="X jack lv2" and for that reason, I believe than media-plugins would be a better place.

Comment 3 Dominique Michel 2023-09-06 20:38:31 UTC

I get that and don't know how to fix it:

 * QA Notice: The following shared libraries lack a SONAME
 * /usr/lib64/liblsp-r3d-glx-lib-1.0.13.so

Maybe an upstream bug.

Comment 4 Dominique Michel 2023-09-06 20:43:33 UTC

And also that:

 * QA Notice: The ebuild is installing to one or more unexpected paths:
 * 
 *   /usr/share/doc/lsp-plugins

but I could not figure out how to fix it with the build system. This is with USE="doc" which install the html doc. The ebuild fix it by moving it to /usr/share/doc/${P}/html into pkg_preinst.