Summary: | app-misc/tracker-miners-3.6_beta: configure doesn't detect btrfs subvolume support | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | poncho <poncho> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | poncho |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://github.com/NixOS/nixpkgs/issues/228639 https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/267 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
meson log from ebuild configure
meson-log.txt testfile.c Use cc.has_header_symbol to check for BTRFS_IOC_INO_LOOKUP |
Description
poncho
2023-08-31 07:34:27 UTC
Could you include meson-log.txt? Created attachment 869080 [details]
meson-log.txt
(In reply to Sam James from comment #1) > Could you include meson-log.txt? log file added. I think this is the relevant part: Running compile: Working directory: /var/tmp/portage/app-misc/tracker-miners-3.6_beta/work/tracker-miners-3.6_beta-build/meson-private/tmp6f8o0dro Command line: x86_64-pc-linux-gnu-gcc /var/tmp/portage/app-misc/tracker-miners-3.6_beta/work/tracker-miners-3.6_beta-build/meson-private/tmp6f8o0dro/testfile.c -o /var/tmp/portage/app-misc/tracker-miners-3.6_beta/work/tracker-miners-3.6_beta-build/meson-private/tmp6f8o0dro/output.exe -march=native -O2 -pipe -DTRACKER_DEBUG -DG_DISABLE_CAST_CHECKS -D_FILE_OFFSET_BITS=64 -O0 -Wl,-O1 -Wl,--as-needed Code: #include <errno.h> #include <fcntl.h> #include <sys/ioctl.h> #include <linux/btrfs.h> int main (int argc, char *argv[]) { struct btrfs_ioctl_ino_lookup_args args = { 0, }; int fd = open ("/", O_RDONLY); int ret = ioctl (fd, BTRFS_IOC_INO_LOOKUP, &args); return (ret < 0 && errno != ENOTTY) ? 1 : 0; } Compiler stdout: Compiler stderr: Program stdout: Program stderr: Checking if "BTRFS_IOC_INO_LOOKUP ioctl is available" runs: NO (1) (In reply to poncho from comment #0) > I'm having issues with tracker and my btrfs subvolumes. If I have the test return true either way, my issues are fixed. So it's really just the configure check that seems wrong. diff --unified --new-file --recursive --show-c-function '--color=auto' tracker-miners-3.6.beta/meson.build tracker-miners-3.6.beta-fix/meson.build --- tracker-miners-3.6.beta/meson.build 2023-08-11 00:18:58.000000000 +0200 +++ tracker-miners-3.6.beta-fix/meson.build 2023-08-31 09:20:46.767479152 +0200 @@ -197,7 +197,7 @@ result = cc.run(''' if result.compiled() and result.returncode() == 0 have_btrfs_ioctl = true else - have_btrfs_ioctl = false + have_btrfs_ioctl = true endif #################################################################### I don't use btrfs and the check succeeds here. I don't think it's related to whether you're using btrfs.
> Checking if "BTRFS_IOC_INO_LOOKUP ioctl is available" runs: YES
I don't see anything in your meson-log.txt that shows why the compile fails.
If you put the contents of the configure test C code into a file and run the command meson says it's executing to build it, what does the compiler say?
Oh, it actually runs the program as well (result = cc.run(...)), so it may compile fine and then fail to run for some reason on your system. Created attachment 869108 [details] testfile.c (In reply to Matt Turner from comment #6) > Oh, it actually runs the program as well (result = cc.run(...)), so it may > compile fine and then fail to run for some reason on your system. The file compiles and runs fine. Returns 1 on my system for some reason. from /proc/mounts: /dev/mapper/luks-XXX / btrfs rw,noatime,compress=zstd:3,ssd,discard=async,space_cache,subvolid=256,subvol=/root 0 0 (In reply to poncho from comment #7) > Created attachment 869108 [details] > testfile.c > > (In reply to Matt Turner from comment #6) > > Oh, it actually runs the program as well (result = cc.run(...)), so it may > > compile fine and then fail to run for some reason on your system. > > The file compiles and runs fine. Returns 1 on my system for some reason. Yeah, returning 1 means it failed. You'll have to debug it to understand why. (In reply to Matt Turner from comment #8) > You'll have to debug it to understand why. I'm sorry but I don't know how to debug the issue further. I'd need some help to do that. adding printf("%d %d %s\n", ret, errno, strerror(errno)); as user, I get: -1 1 Operation not permitted as root, I get: -1 2 No such file or directory Created attachment 869474 [details, diff] Use cc.has_header_symbol to check for BTRFS_IOC_INO_LOOKUP A fix was merged upstream. https://gitlab.gnome.org/GNOME/tracker-miners/-/commit/c08fbe0650d4a2ae915a21764f54c02eda9406d5 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=591b0d2ae92492651b64ed0e495b5c08d9e85817 commit 591b0d2ae92492651b64ed0e495b5c08d9e85817 Author: Guillermo Joandet <gjoandet@gmail.com> AuthorDate: 2023-09-06 13:45:30 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2023-09-06 14:42:14 +0000 app-misc/tracker-miners: Version bump to 3.6_rc Closes: https://bugs.gentoo.org/913363 Closes: https://github.com/gentoo/gentoo/pull/32653 Signed-off-by: Guillermo Joandet <gjoandet@gmail.com> Signed-off-by: Matt Turner <mattst88@gentoo.org> app-misc/tracker-miners/Manifest | 1 + .../tracker-miners/tracker-miners-3.6_rc.ebuild | 177 +++++++++++++++++++++ 2 files changed, 178 insertions(+) |