Bug 913133

Summary:	net-misc/apt-cacher-ng-3.7.4_p1-r2 fails to compile (GLIBC-2.38-SYSTEM): meta.h:326:44: error: operator ! has no right operand
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	John Helmert III <ajak>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hyedad, leonchik1976, richliu, tanekliang
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://launchpad.net/bugs/2036822
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	911592
Attachments:	build.log Fix compile error

Description Agostino Sarubbo gentoo-dev

2023-08-28 07:10:03 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/apt-cacher-ng-3.7.4_p1-r2 fails to compile (GLIBC-2.38-SYSTEM).
Discovered on: amd64 (internal ref: glibc2.38_tinderbox)

NOTE:
(GLIBC-2.38-SYSTEM) in the summary means that the bug was found on a machine that runs glibc-2.38 but this bug MAY or MAY NOT BE related to the new libc version

Comment 1 Agostino Sarubbo gentoo-dev

2023-08-28 07:10:05 UTC

Created attachment 868846 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2023-08-28 07:10:07 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: client/CMakeFiles/in.acng.dir/client.cc.o 
FAILED: client/CMakeFiles/in.acng.dir/__/src/acerrno.cc.o 
FAILED: src/CMakeFiles/supacng.dir/acbuf.cc.o 
FAILED: src/CMakeFiles/supacng.dir/acfg.cc.o 
FAILED: src/CMakeFiles/supacng.dir/acfg_defaults.cc.o 
FAILED: src/CMakeFiles/supacng.dir/aclogger.cc.o 
FAILED: src/CMakeFiles/supacng.dir/astrop.cc.o 
FAILED: src/CMakeFiles/supacng.dir/caddrinfo.cc.o 
FAILED: src/CMakeFiles/supacng.dir/dirwalk.cc.o 
FAILED: src/CMakeFiles/supacng.dir/dlcon.cc.o 
FAILED: src/CMakeFiles/supacng.dir/fileio.cc.o 
FAILED: src/CMakeFiles/supacng.dir/fileitem.cc.o 
FAILED: src/CMakeFiles/supacng.dir/filereader.cc.o 
FAILED: src/CMakeFiles/supacng.dir/header.cc.o 
FAILED: src/CMakeFiles/supacng.dir/meta.cc.o 
FAILED: src/CMakeFiles/supacng.dir/sockio.cc.o 
--   Package 'fuse', required by 'virtual:world', not found
/var/tmp/portage/net-misc/apt-cacher-ng-3.7.4_p1-r2/work/apt-cacher-ng-debian-3.7.4-1/src/meta.h:326:44: error: operator '!' has no right operand

Comment 3 Richard Liu 2024-01-18 17:01:55 UTC

Created attachment 882537 [details, diff]
Fix compile error

Comment 4 Richard Liu 2024-01-18 17:02:51 UTC

I have made a patch for this issue, and it seems work for me on my ARM64 platform. 

Seems compile error caused by new gcc version, and apt-cacher-ng has been long time no update.

Comment 5 Karl Hakimian 2024-01-18 17:57:52 UTC

That patched work for me. Thanks.

Comment 6 Leonid Kopylov 2024-01-18 18:12:35 UTC

(In reply to Richard Liu from comment #3)
> Created attachment 882537 [details, diff] [details, diff]
> Fix compile error

works both for amd64 and arm64

Comment 7 Larry the Git Cow gentoo-dev

2024-03-24 14:16:24 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=32043b1ee1d7473b06ddddd83c5c12505273bd91

commit 32043b1ee1d7473b06ddddd83c5c12505273bd91
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-24 14:15:10 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-24 14:15:10 +0000

    net-misc/apt-cacher-ng: fix build with glibc-2.38
    
    Closes: https://bugs.gentoo.org/913133
    Thanks-to: Richard Liu <richliu@techarea.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../apt-cacher-ng/apt-cacher-ng-3.7.4_p1-r2.ebuild |  3 +-
 .../apt-cacher-ng-3.7.4-strlcpy-glibc-2.38.patch   | 41 ++++++++++++++++++++++
 2 files changed, 43 insertions(+), 1 deletion(-)

Comment 8 Sam James archtester

2024-03-24 14:17:10 UTC

*** Bug 907882 has been marked as a duplicate of this bug. ***