Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 912789

Summary: dev-util/android-tools-34.0.0 - /.../jsonpb.cpp: error: class absl::lts_20230125::string_view has no member named as_string
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Zac Medico <zmedico>
Status: RESOLVED FIXED    
Severity: normal CC: atoth, christian, contyk, finkandreas, me, tanekliang, vowstar
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 912819    
Attachments: emerge-info.txt
dev-util:android-tools-34.0.0:20230821-194036.log.xz
emerge-history.txt.xz
environment
etc.clang.tar.xz
etc.portage.tar.xz
logs.tar.xz
temp.tar.xz
Reformatted patch

Description Toralf Förster gentoo-dev 2023-08-21 20:13:35 UTC
   43 |   google::protobuf::util::JsonOptions options;
      |                                       ^~~~~~~
In file included from /var/tmp/portage/dev-util/android-tools-34.0.0/work/android-tools-34.0.0/vendor/extras/libjsonpb/parse/jsonpb.cpp:22:
/usr/include/google/protobuf/util/json_util.h:45:7: note: declared here
   45 | using JsonOptions ABSL_DEPRECATED("use JsonPrintOptions instead") =
      |       ^~~~~~~~~~~
/var/tmp/portage/dev-util/android-tools-34.0.0/work/android-tools-34.0.0/vendor/extras/libjsonpb/parse/jsonpb.cpp:54:52: error: 'class absl::lts_20230125::string_view' has no member named 'as_string'
   54 |     return MakeError<std::string>(status.message().as_string());
      |                                                    ^~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no_multilib-20230816-090515

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-13 *
clang/llvm (if any):
clang version 16.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/16/bin
Configuration file: /etc/clang/clang.cfg
/usr/lib/llvm/16
16.0.6
Python 3.11.4
Available Ruby profiles:
  [1]   ruby31 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.71.1
  [2]   rust-1.71.1 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 11.0.19_p7 [openjdk-bin-11]
2)	Eclipse Temurin JDK 17.0.7_p7 [openjdk-bin-17]
*)	Eclipse Temurin JDK 8.372_p07 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm
  [2]   openjdk-bin-11 
  [3]   openjdk-bin-17 

php cli (if any):
go version go1.21.0 linux/amd64

  HEAD of ::gentoo
commit 6f80b9c73eb2ade01ae6f20b1dfad66160121a97
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Mon Aug 21 18:31:43 2023 +0000

    2023-08-21 18:31:42 UTC

emerge -qpvO dev-util/android-tools
[ebuild   R   ] dev-util/android-tools-34.0.0  USE="python -udev" PYTHON_TARGETS="python3_11 -python3_10"
Comment 1 Toralf Förster gentoo-dev 2023-08-21 20:13:36 UTC
Created attachment 868402 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-08-21 20:13:37 UTC
Created attachment 868403 [details]
dev-util:android-tools-34.0.0:20230821-194036.log.xz
Comment 3 Toralf Förster gentoo-dev 2023-08-21 20:13:38 UTC
Created attachment 868404 [details]
emerge-history.txt.xz
Comment 4 Toralf Förster gentoo-dev 2023-08-21 20:13:40 UTC
Created attachment 868405 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2023-08-21 20:13:41 UTC
Created attachment 868406 [details]
etc.clang.tar.xz
Comment 6 Toralf Förster gentoo-dev 2023-08-21 20:13:42 UTC
Created attachment 868407 [details]
etc.portage.tar.xz
Comment 7 Toralf Förster gentoo-dev 2023-08-21 20:13:42 UTC
Created attachment 868408 [details]
logs.tar.xz
Comment 8 Toralf Förster gentoo-dev 2023-08-21 20:13:43 UTC
Created attachment 868409 [details]
temp.tar.xz
Comment 10 Mike Lothian 2023-08-21 22:45:57 UTC
Created attachment 868434 [details, diff]
Reformatted patch

This applies cleanly
Comment 11 Andrey Volkov 2023-08-22 04:36:09 UTC
This patch works for me
https://github.com/nmeum/android-tools/pull/120#issuecomment-1621066529
Comment 12 Geoff Leach 2023-08-22 20:57:57 UTC
patch in comment #11 works for me
Comment 13 Larry the Git Cow gentoo-dev 2023-08-22 21:23:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6715861d4786d75621d8ed980121b37be523f5bb

commit 6715861d4786d75621d8ed980121b37be523f5bb
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-22 21:23:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-22 21:23:15 +0000

    dev-util/android-tools: fix build w/ new protobuf
    
    Closes: https://bugs.gentoo.org/912789
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/android-tools/Manifest                    |  1 +
 dev-util/android-tools/android-tools-34.0.1.ebuild | 95 ++++++++++++++++++++++
 .../files/android-tools-34.0.0-protobuf.patch      | 41 ++++++++++
 3 files changed, 137 insertions(+)