| Summary: | mail-client/alpine-2.26-r2 - patch -p1 failed with /var/tmp/portage/mail-client/alpine-2.26-r2/files/alpine-2.26-fix-clang16-build | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Robert G. Siebeck <gentoo.2019> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | brahmajit.xyz, holger, proxy-maint |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/32417 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
emerge-info.txt
emerge-history.txt environment etc.clang.tar.xz etc.portage.tar.xz mail-client:alpine-2.26-r2:20230819-152735.log temp.tar.xz |
||
|
Description
Toralf Förster
2023-08-19 15:37:45 UTC
Created attachment 868223 [details]
emerge-info.txt
Created attachment 868224 [details]
emerge-history.txt
Created attachment 868225 [details]
environment
Created attachment 868226 [details]
etc.clang.tar.xz
Created attachment 868227 [details]
etc.portage.tar.xz
Created attachment 868228 [details]
mail-client:alpine-2.26-r2:20230819-152735.log
Created attachment 868229 [details]
temp.tar.xz
Can someone reproduce this? I cannot:
$ebuild alpine-2.26-r2.ebuild prepare
>>> Unpacking source...
>>> Unpacking alpine-2.26.tar.xz to /tmp/portage/mail-client/alpine-2.26-r2/work
>>> Unpacking alpine-2.26-chappa-5.patch.gz to /tmp/portage/mail-client/alpine-2.26-r2/work
>>> Source unpacked in /tmp/portage/mail-client/alpine-2.26-r2/work
>>> Preparing source in /tmp/portage/mail-client/alpine-2.26-r2/work/alpine-2.26 ...
* Applying alpine-2.26-chappa-5.patch ...
* Applying alpine-2.26-fix-clang16-build.patch ...
* Running eautoreconf in '/tmp/portage/mail-client/alpine-2.26-r2/work/alpine-2.26' ...
Works fine on several machines.
Probably depends on USE combination, as this ebuild conditionally patches. (In reply to Sam James from comment #9) > Probably depends on USE combination, as this ebuild conditionally patches. Yup: -chappa now fails for me too. I wonder if it wouldn't make more sense to use the chappa patch unconditionally, or even encourage upstream to merge it. The all-in-one patch is a whopping ~800k and the functionality it adds is more than "nice to have". I plan to address the remaining problems with -Wstrict-prototypes and will contact upstream about this. (In reply to Holger Hoffstätte from comment #11) > I plan to address the remaining problems with -Wstrict-prototypes and will > contact upstream about this. Thanks for that, I planned to send it upstream. But got busy with IRL and GSoC work. Also, the initial patch is quite hacky. A proper fix from the developer would be much better IMO. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37cdeedd76ed2f1f9d169431ac98c9e40afe9372 commit 37cdeedd76ed2f1f9d169431ac98c9e40afe9372 Author: Brahmajit Das <brahmajit.xyz@gmail.com> AuthorDate: 2023-08-23 06:09:34 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-08-26 04:01:25 +0000 mail-client/alpine: Fix patch failed with -chappa use flag Conditionally patch, based on the chappa USE flag. Regression was introduced by commit 48ed3cf79fcd349f5014d31ff4d4f18abb897f72 Closes: https://bugs.gentoo.org/912596 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/32417 Signed-off-by: Sam James <sam@gentoo.org> mail-client/alpine/alpine-2.26-r2.ebuild | 6 +- .../alpine-2.26-fix-clang16-build-no-chappa.patch | 165 +++++++++++++++++++++ 2 files changed, 170 insertions(+), 1 deletion(-) |
