Bug 912334 – sys-process/systemd-cron-1.16.7: installs no files

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sam James 2023-08-16 02:15:42 UTC]

systemd-cron-1.16.20 doesn't appear to install anything.

At first glance, there's at least a '|| die' missing from src_configure's manual call to `./configure`.

From iwdevtools:
```
 * CMP: =sys-process/systemd-cron-1.15.20 with sys-process/systemd-cron-1.16.7/image
 *  FILES:-usr/bin/crontab-systemd
 *  FILES:-usr/lib/systemd-cron/boot_delay
 *  FILES:-usr/lib/systemd-cron/mail_on_failure
 *  FILES:-usr/lib/systemd-cron/remove_stale_stamps
 *  FILES:-usr/lib/systemd/system-generators/systemd-crontab-generator
 *  FILES:-usr/lib/systemd/system/cron-daily.service
 *  FILES:-usr/lib/systemd/system/cron-daily.target
 *  FILES:-usr/lib/systemd/system/cron-daily.timer
 *  FILES:-usr/lib/systemd/system/cron-failure@.service
 *  FILES:-usr/lib/systemd/system/cron-hourly.service
 *  FILES:-usr/lib/systemd/system/cron-hourly.target
 *  FILES:-usr/lib/systemd/system/cron-hourly.timer
 *  FILES:-usr/lib/systemd/system/cron-monthly.service
 *  FILES:-usr/lib/systemd/system/cron-monthly.target
 *  FILES:-usr/lib/systemd/system/cron-monthly.timer
 *  FILES:-usr/lib/systemd/system/cron-update.path
 *  FILES:-usr/lib/systemd/system/cron-update.service
 *  FILES:-usr/lib/systemd/system/cron-weekly.service
 *  FILES:-usr/lib/systemd/system/cron-weekly.target
 *  FILES:-usr/lib/systemd/system/cron-weekly.timer
 *  FILES:-usr/lib/systemd/system/cron.target
 *  FILES:-usr/share/man/man1/crontab-systemd.1.xz
 *  FILES:-usr/share/man/man5/anacrontab.5.xz
 *  FILES:-usr/share/man/man5/crontab-systemd.5.xz
 *  FILES:-usr/share/man/man7/systemd.cron.7.xz
 *  FILES:-usr/share/man/man8/systemd-crontab-generator.8.xz
 *   SIZE: 0.07MiB -> 0.01MiB, 28 -> 2 files
 * ------> FILES(-26) SIZE(-80.79%)
```

[Comment 1 Sam James 2023-08-16 02:16:55 UTC]

Sorry, make that 1.16.7.

[Comment 2 Sam James 2023-08-16 02:17:03 UTC]

Created attachment 867924 [details]
build.log

[Comment 3 Larry the Git Cow 2023-08-16 02:18:43 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2bde10ee7853e209ed68762e6c0795c08df2f17

commit f2bde10ee7853e209ed68762e6c0795c08df2f17
Author:     Sam James <[e-mail]>
AuthorDate: 2023-08-16 02:18:27 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-08-16 02:18:27 +0000

    profiles: mask broken systemd-cron-1.16.7
    
    Bug: https://bugs.gentoo.org/912334
    Signed-off-by: Sam James <[e-mail]>

 profiles/package.mask | 4 ++++
 1 file changed, 4 insertions(+)

[Comment 4 Larry the Git Cow 2023-08-16 14:37:36 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=44152e2ec8c240c3c2e6c1c7c3846225b8cce851

commit 44152e2ec8c240c3c2e6c1c7c3846225b8cce851
Author:     Richard Freeman <[e-mail]>
AuthorDate: 2023-08-16 14:34:18 +0000
Commit:     Richard Freeman <[e-mail]>
CommitDate: 2023-08-16 14:35:22 +0000

    sys-process/systemd-cron: Fix configure due to upstream refactor.
    
    Bug: https://bugs.gentoo.org/912334
    Signed-off-by: Richard Freeman <[e-mail]>

 sys-process/systemd-cron/systemd-cron-1.16.7.ebuild | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

[Comment 5 Richard Freeman 2023-08-16 14:38:38 UTC]

I fixed the installation issues - upstream refactored a bunch of things, including configure.  

I'm going to leave this masked a bit longer for additional testing.

[Comment 6 Sam James 2023-08-17 06:37:34 UTC]

commit 75358cead992cc1081f4dd728bce053251fb1491
Author: Richard Freeman <[e-mail]>
Date:   Wed Aug 16 15:39:44 2023 -0400

    sys-process/systemd-cron: catch configure errors in future

    Signed-off-by: Richard Freeman <[e-mail]>

commit e35d715ebd098067176566bd065ee65340b5ed6a
Author: Richard Freeman <[e-mail]>
Date:   Wed Aug 16 10:45:15 2023 -0400

    sys-process/systemd-cron: use split-usr USE flag to detect split usr

    This approach is the same as used by sys-apps/systemd-9999.

    Signed-off-by: Richard Freeman <[e-mail]>

commit 00b331aac5089037c01d00176d1ed7bd1cb4e4fc
Author: Richard Freeman <[e-mail]>
Date:   Wed Aug 16 10:39:37 2023 -0400

    sys-process/systemd-cron: revbump since installed files change

    Signed-off-by: Richard Freeman <[e-mail]>

[Comment 7 Sam James 2023-08-17 06:37:58 UTC]

(In reply to Richard Freeman from comment #5)
> I fixed the installation issues - upstream refactored a bunch of things,
> including configure.  
> 
> I'm going to leave this masked a bit longer for additional testing.

My mask was only for =1.16.7 so it's been unmasked since your fixes. Not much point in masking it now I suppose, but up to you, I don't mind either way.

[Comment 8 Larry the Git Cow 2023-08-17 16:58:26 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5801f4d8940b5471b79e392ee024512334c62388

commit 5801f4d8940b5471b79e392ee024512334c62388
Author:     Richard Freeman <[e-mail]>
AuthorDate: 2023-08-17 16:57:22 +0000
Commit:     Richard Freeman <[e-mail]>
CommitDate: 2023-08-17 16:57:22 +0000

    profiles: remove systemd-cron mask
    
    Closes: https://bugs.gentoo.org/912334
    Signed-off-by: Richard Freeman <[e-mail]>

 profiles/package.mask | 4 ----
 1 file changed, 4 deletions(-)