Bug 912087 – app-admin/sysstat is missing large file support

• Product: Gentoo Linux
• Status: UNCONFIRMED ---

[Description Allen Webb 2023-08-11 15:14:41 UTC]

app-admin/sysstat is missing large file support:

```
15:02:41.761  * QA Notice: The following files were not built with LFS support:
15:02:41.778  *   Please see https://issuetracker.google.com/201531268 for details.
15:02:41.796  * __open_2,fopen,readdir,stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/image/usr/bin/pidstat
15:02:41.800  * readdir,fopen,stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/image/usr/bin/mpstat
15:02:41.804  * lseek,stat,__open_2,fopen,readdir,scandir,alphasort /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/image/usr/bin/sadf
15:02:41.809  * fopen,readdir,stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/image/usr/bin/cifsiostat
15:02:41.813  * stat,lseek,__open_2,fopen,readdir,scandir,alphasort /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/image/usr/bin/sar
15:02:41.817  * readdir,stat,fopen /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/image/usr/bin/tapestat
15:02:41.821  * stat,fopen,readdir,scandir,alphasort /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/image/usr/bin/iostat
15:02:41.825  * open,ftruncate,__open_2,fopen,stat,readdir,statvfs /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/image/usr/lib/sa/sadc
15:02:41.841  * Full build files:
__open_2,fopen,readdir,stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/pidstat
stat,lseek,__open_2 /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sa_common.o
fopen /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sa_wrap.o
readdir,fopen,stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/mpstat
fopen,readdir,stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/ioconf.o
stat,lseek /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sar.o
fopen,readdir,statvfs /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/rd_stats.o
lseek,stat,__open_2,fopen,readdir,scandir,alphasort /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sadf
lseek /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sadf.o
readdir,stat,fopen,statvfs /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/count.o
fopen,readdir,stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/cifsiostat
open,ftruncate,__open_2 /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sadc.o
stat,lseek,__open_2,fopen,readdir,scandir,alphasort /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sar
fopen /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/cifsiostat.o
open,ftruncate,__open_2,fopen,stat,readdir,statvfs /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sadc
readdir,stat,fopen /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/tapestat
stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sa_common_light.o
readdir,fopen /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/mpstat.o
readdir,stat,fopen,scandir,alphasort /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/common.o
lseek /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/sa_conv.o
readdir,stat,fopen /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/tapestat.o
readdir,stat /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/common_light.o
readdir,stat,fopen /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/count_light.o
stat,fopen,readdir /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/iostat.o
__open_2,fopen,readdir /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/pidstat.o
fopen /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/rd_stats_light.o
stat,fopen,readdir,scandir,alphasort /build/arm-generic/tmp/portage/app-admin/sysstat-12.6.2-r1/work/sysstat-12.6.2/iostat
```

I didn't see any usage of off_t or struct dirent that would cause API breakages. https://github.com/sysstat/sysstat (also sysstat doesn't look like a library; I wouldn't expect API breakages from an executable).

This resolves the issue for me:

diff --git a/app-admin/sysstat/sysstat-12.6.2-r1.ebuild b/app-admin/sysstat/sysstat-12.6.2-r1.ebuild
index 144c5c674..2311889d9 100644
--- a/app-admin/sysstat/sysstat-12.6.2-r1.ebuild
+++ b/app-admin/sysstat/sysstat-12.6.2-r1.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=7
 
-inherit systemd toolchain-funcs
+inherit flag-o-matic systemd toolchain-funcs
 
 DESCRIPTION="System performance tools for Linux"
 HOMEPAGE="http://sebastien.godard.pagesperso-orange.fr/"
@@ -46,6 +46,10 @@ src_prepare() {
 }
 
 src_configure() {
+       append-lfs-flags
+       # Only CFLAGS is used so append CPPFLAGS
+       append-cflags "${CPPFLAGS}"
+
        tc-export AR
 
        sa_lib_dir=/usr/lib/sa \

Reproducible: Always

[Comment 1 Marek Szuba (RETIRED) 2024-04-05 22:45:23 UTC]

Could you please post here the output of emerge --info as well as the sysstat build log?