Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 911710

Summary: www-client/firefox-116: fails to compile with dev-util/pkgconf-2.0.0 (--modversion requested with multiple packages, output would be ambiguous)
Product: Gentoo Linux Reporter: abanoub <abrayad07>
Component: Current packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: RESOLVED FIXED    
Severity: major CC: base-system, douzzer, floppym, gentoo.qxrin, ionen, sam
Priority: Normal    
Version: unspecified   
Hardware: AMD64   
OS: Linux   
See Also: https://github.com/rust-lang/pkg-config-rs/issues/150
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 911721    
Attachments: The (compressed) log
Output of emerge --info

Description abanoub 2023-08-04 14:37:15 UTC
Firefox 116 cannot be emerged due to an internal pkgconf error with dbus. The logs are attached.
Comment 1 abanoub 2023-08-04 14:41:10 UTC
Created attachment 867020 [details]
The (compressed) log
Comment 2 abanoub 2023-08-04 14:43:00 UTC
Created attachment 867021 [details]
Output of emerge --info
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-08-04 14:44:36 UTC
 2:21.28 [libdbus-sys 0.2.2] pkg_config failed: `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" PKG_CONFIG_ALLOW_SYSTEM_LIBS="1" PKG_CONFIG_PATH="/var/tmp/portage/www-client/firefox-116.0/temp/python3.11/pkgconfig" "/usr/bin/x86_64-pc-linux-gnu-pkg-config" "--modversion" "dbus-1" "dbus-1 >= 1.6"` did not exit successfully: exit status: 1
 2:21.28 [libdbus-sys 0.2.2] --- stderr
 2:21.28 [libdbus-sys 0.2.2] pkgconf: --modversion requested with multiple packages, output would be ambiguous
Comment 4 Ionen Wolkens gentoo-dev 2023-08-04 14:47:32 UTC
tl;dr pkgconf-2.0.0 no longer takes multiple packages with --modversion, albeit in firefox's case it's a bit weirder because it seemingly(?) wastefully checks the same package twice

pkgconf-1.8.1:
    $ pkg-config --modversion dbus-1 "dbus-1 >= 1.6"
    1.15.6
    1.15.6

pkgconf-2.0.0:
    $ pkg-config --modversion dbus-1 "dbus-1 >= 1.6"
    pkgconf: --modversion requested with multiple packages, output would be ambiguous

Imagine more packages may be affected if they happened to do a custom all-at-once --modversion check, albeit I don't think it's common.
Comment 5 Ionen Wolkens gentoo-dev 2023-08-04 15:07:44 UTC
(In reply to Ionen Wolkens from comment #4)
> Imagine more packages may be affected if they happened to do a custom
> all-at-once --modversion check, albeit I don't think it's common.
...well, maybe could be widespread in rust land.

The libdbus-sys crate uses the pkg-config crate to do that >= 1.6 version check. So can also be reproduced with media-sound/rescrobbled which also uses it.

Unsure if it's doing incorrect usage of the pkg-config crate or if the pkg-config crate is doing something wrong when a version check is requested.
Comment 6 Ionen Wolkens gentoo-dev 2023-08-04 17:26:51 UTC
(In reply to Ionen Wolkens from comment #5)
> Unsure if it's doing incorrect usage of the pkg-config crate or if the
> pkg-config crate is doing something wrong when a version check is requested.
Albeit in the crates' case it's just about being a duplicate, there are others checking two different packages at once, e.g. qtgui:5, qtopengl:%, and probably a lot of qmake stuff will do:

    /usr/bin/pkg-config --modversion glib-2.0 gthread-2.0
    pkgconf: --modversion requested with multiple packages, output would be ambiguous

Giving me the impression this may be better off reverted in pkgconf unless it's clear that we're really moving forward with banning this type of usage.
Comment 7 Daniel Pouzzner 2023-08-05 00:32:53 UTC
same syndrome on =gnome-base/librsvg-2.56.3:

  cargo:warning=`PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" PKG_CONFIG_PATH="/tmp/portage/gnome-base/librsvg-2.56.3/temp/pkgconfig:/tmp/portage/gnome-base/librsvg-2.56.3/temp/python3.11/pkgconfig" "/usr/bin/x86_64-pc-linux-gnu-pkg-config" "--modversion" "glib-2.0" "glib-2.0 >= 2.56"` did not exit successfully: exit status: 1
  --- stderr
  pkgconf: --modversion requested with multiple packages, output would be ambiguous
Comment 8 Larry the Git Cow gentoo-dev 2023-08-12 04:44:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=354924b6e7a9e7a54eaa62000020a7d79c028a0c

commit 354924b6e7a9e7a54eaa62000020a7d79c028a0c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-12 04:40:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-12 04:40:45 +0000

    dev-util/pkgconf: add 2.0.1, drop 2.0.0
    
    Closes: https://bugs.gentoo.org/911721
    Closes: https://bugs.gentoo.org/911710
    Closes: https://bugs.gentoo.org/911716
    Closes: https://bugs.gentoo.org/911718
    Closes: https://bugs.gentoo.org/911719
    Closes: https://bugs.gentoo.org/911746
    Closes: https://bugs.gentoo.org/911924
    Closes: https://bugs.gentoo.org/911937
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/pkgconf/Manifest                                       | 2 +-
 dev-util/pkgconf/{pkgconf-2.0.0.ebuild => pkgconf-2.0.1.ebuild} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)