Bug 911176 – net-analyzer/tcpdump: please add Large File Support (LFS)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Zi Lin 2023-07-24 22:36:06 UTC]

Created attachment 866173 [details, diff]
add lfs support patch

We would like to add lfs support flags in the ebuild to consistently use large file compatible syscalls.

Without it, ChromiumOS build will constantly fail on 32-bit boards.

15:29:02.206  * QA Notice: The following files were not built with LFS support:
15:29:02.216  *   Please see https://issuetracker.google.com/201531268 for details.
15:29:02.227  * fopen,__open_2,fstat /usr/sbin/tcpdump
15:29:02.238  * Full build files:
fopen,__open_2,fstat /build/arm-generic/tmp/portage/net-analyzer/tcpdump-4.99.4/work/tcpdump-4.99.4/tcpdump.o
fopen,__open_2,fstat /build/arm-generic/tmp/portage/net-analyzer/tcpdump-4.99.4/work/tcpdump-4.99.4/tcpdump
fopen /build/arm-generic/tmp/portage/net-analyzer/tcpdump-4.99.4/work/tcpdump-4.99.4/print-esp.o
fopen /build/arm-generic/tmp/portage/net-analyzer/tcpdump-4.99.4/work/tcpdump-4.99.4/addrtoname.o

I attach a patch that fixes this issue. Since this package is to install the binary of tcpdump, this change is unlikely to cause ABI breakage.

[Comment 1 Sam James 2023-07-26 04:57:38 UTC]

Could you comment your `Signed-off-by: name <email>`? Thanks.

[Comment 2 Zi Lin 2023-07-26 21:30:21 UTC]

Please use [e-mail], Thanks!

[Comment 3 Sam James 2023-07-27 07:32:36 UTC]

Thanks!

[Comment 4 Larry the Git Cow 2023-07-27 07:35:50 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e570a6b3de1540389fb45a1af263be3a426269df

commit e570a6b3de1540389fb45a1af263be3a426269df
Author:     Sam James <[e-mail]>
AuthorDate: 2023-07-27 07:35:20 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-07-27 07:35:38 +0000

    net-analyzer/tcpdump: build with LFS
    
    Closes: https://bugs.gentoo.org/911176
    Signed-off-by: Sam James <[e-mail]>

 .../tcpdump/files/tcpdump-4.99.4-lfs.patch         | 22 ++++++++++++++++++++++
 net-analyzer/tcpdump/files/tcpdump-9999-lfs.patch  | 22 ++++++++++++++++++++++
 ...dump-4.99.4.ebuild => tcpdump-4.99.4-r1.ebuild} |  1 +
 net-analyzer/tcpdump/tcpdump-9999.ebuild           |  1 +
 4 files changed, 46 insertions(+)

[Comment 5 Sam James 2023-07-27 07:36:01 UTC]

I ended up sending a patch upstream for AC_SYS_LARGEFILE and throwing that in.

[Comment 6 Zi Lin 2023-08-01 17:54:40 UTC]

Thank you very much!