| Summary: | distutils-r1.eclass: Inconsistency in BUILD_DIR eclass documentation in inherited python eclasses leads to false IndirectInherits warning in pkgcheck with DISTUTILS_SINGLE_IMPL=1 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Alfred Wingate <parona> |
| Component: | Eclasses | Assignee: | Python Gentoo Team <python> |
| Status: | RESOLVED FIXED | ||
| Severity: | trivial | Keywords: | PullRequest |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/36945 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Alfred Wingate
2023-07-22 02:39:27 UTC
Ebuilds to reproduce the warning
~ cat test-1.ebuild
# Copyright 2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
DISTUTILS_USE_PEP517=hatchling
PYTHON_COMPAT=( pypy3 python3_{11..12} )
inherit distutils-r1
DESCRIPTION="lorem ipsum"
HOMEPAGE="http://example.com/"
LICENSE="all-rights-reserved"
SLOT="0"
KEYWORDS="~amd64"
distutils_enable_tests pytest
python_test() {
echo "${BUILD_DIR}"
}
$ cat test-2.ebuild
# Copyright 2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
DISTUTILS_SINGLE_IMPL=1
DISTUTILS_USE_PEP517=hatchling
PYTHON_COMPAT=( pypy3 python3_{11..12} )
inherit distutils-r1
DESCRIPTION="lorem ipsum"
HOMEPAGE="http://example.com/"
LICENSE="all-rights-reserved"
SLOT="0"
KEYWORDS="~amd64"
distutils_enable_tests pytest
python_test() {
echo "${BUILD_DIR}"
}
My own opinion on this is that documenting BUILD_DIR in python-utils-r1.eclass instead would make the most sense, especially as the eclass has some mention of the variable already while not documenting it twice for the same purpose. And just to make it clear as I have omitted it in the initial comment. The warning comes from pkgcheck, so to reproduce it the fourth step would be to run pkgcheck scan. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c9973d691bf1842f7a1fcefc90e31872054bc94 commit 4c9973d691bf1842f7a1fcefc90e31872054bc94 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2024-06-01 09:22:32 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2024-06-14 12:26:06 +0000 distutils-r1.eclass: Document BUILD_DIR for consistency Closes: https://bugs.gentoo.org/910661 Signed-off-by: Michał Górny <mgorny@gentoo.org> eclass/distutils-r1.eclass | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) |
