Summary: | sci-electronics/kicad bundles dev-libs/libfmt | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Justin Keogh <bugs.gentoo.org> |
Component: | Current packages | Assignee: | Zoltan Puskas <zoltan> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | andrewammerlaan, proxy-maint |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge --info
kicad_system_fmt.patch Patch to support libfmt-9 kicad_system_fmt.patch |
Description
Justin Keogh
2023-07-19 05:51:15 UTC
Created attachment 865774 [details]
emerge --info
Upstream master recently switched to fmt 10. So I unmasked dev-libs/libfmt-10.0.0 on my system. Same result. * Detected file collision(s): * * /usr/lib64/libfmt.so.10.0.0 * /usr/lib64/pkgconfig/fmt.pc * /usr/lib64/cmake/fmt/fmt-config-version.cmake * /usr/lib64/cmake/fmt/fmt-targets.cmake * /usr/lib64/cmake/fmt/fmt-config.cmake * /usr/lib64/cmake/fmt/fmt-targets-relwithdebinfo.cmake * /usr/include/fmt/ranges.h * /usr/include/fmt/format.h * /usr/include/fmt/core.h * /usr/include/fmt/args.h * /usr/include/fmt/chrono.h * /usr/include/fmt/printf.h * /usr/include/fmt/std.h * /usr/include/fmt/os.h * /usr/include/fmt/xchar.h * /usr/include/fmt/ostream.h * /usr/include/fmt/compile.h * /usr/include/fmt/color.h * /usr/include/fmt/format-inl.h * /usr/lib64/libfmt.so.10 * /usr/lib64/libfmt.so * * Searching all installed packages for file collisions... * * Press Ctrl-C to Stop * * dev-libs/libfmt-10.0.0:0::gentoo * /usr/include/fmt/args.h * /usr/include/fmt/chrono.h * /usr/include/fmt/color.h * /usr/include/fmt/compile.h * /usr/include/fmt/core.h * /usr/include/fmt/format-inl.h * /usr/include/fmt/format.h * /usr/include/fmt/os.h * /usr/include/fmt/ostream.h * /usr/include/fmt/printf.h * /usr/include/fmt/ranges.h * /usr/include/fmt/std.h * /usr/include/fmt/xchar.h * /usr/lib64/cmake/fmt/fmt-config-version.cmake * /usr/lib64/cmake/fmt/fmt-config.cmake * /usr/lib64/cmake/fmt/fmt-targets-relwithdebinfo.cmake * /usr/lib64/cmake/fmt/fmt-targets.cmake * /usr/lib64/libfmt.so.10 * /usr/lib64/libfmt.so.10.0.0 * /usr/lib64/pkgconfig/fmt.pc * * Package 'sci-electronics/kicad-9999' NOT merged due to file * collisions. If necessary, refer to your elog messages for the whole * content of the above message. * * The following package has failed to build, install, or execute postinst: * * (sci-electronics/kicad-9999:0/0::gentoo https://gitlab.com/kicad/code/kicad/-/blob/master/CMakeLists.txt#L1036 add_subdirectory( thirdparty ) https://gitlab.com/kicad/code/kicad/-/blob/master/thirdparty/CMakeLists.txt#L33 add_subdirectory( fmt ) We need a way to disable the building of thirdparty libs and use system libs as it is for glew. My last successful install of sci-electronics/kicad-9999 was 6. Jul 07:16 /usr/bin/kicad equery f kicad does not show fmt. Created attachment 865806 [details, diff]
kicad_system_fmt.patch
A quick patch based on my analysis above.
Seems to work.
Please test it.
Should kicad ebuild have a dep on dev-libs/libfmt then? With slot?
It seems that Kicad decided witch version of libfmt, they moved to 10 and that creates a compilation problem. The attached patch allows kicad to compile with libfmt-9. Created attachment 866006 [details, diff]
Patch to support libfmt-9
(In reply to Alexandre Ferreira from comment #4) > It seems that Kicad decided witch version of libfmt, they moved to 10 and > that creates a compilation problem. The attached patch allows kicad to > compile with libfmt-9. Would it work if we remove the version number there? https://gitlab.com/kicad/code/kicad/-/issues/15306 "Built-in fmt and system fmt conflict" https://gitlab.com/kicad/code/kicad/-/commit/b95b07e54dffa13096f747c049b600bbfe3c5913 "Turn off the FMT_INSTALL opt" So should we still disable the build of bundled fmt and use the system libfmt for the kicad build even if upstream seems to not want that? Me - yes. Is it even still built after the upstream change? (In reply to jospezial from comment #8) > Is it even still built after the upstream change? Yes! They disabled the install of libfmt only. Not the build. Created attachment 866821 [details, diff]
kicad_system_fmt.patch
Updated to latest upstream change.
The libfmt-9 change should be done in another patch.
|