Bug 910189

Summary:	games-board/gnome-mahjongg-3.40.0 missing dependency gui-libs/libadwaita:1[vala]
Product:	Gentoo Linux	Reporter:	Peter Fox <gentoo>
Component:	Current packages	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	UNCONFIRMED ---
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/36314
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	emerge info build log Proposed patch

Description Peter Fox 2023-07-10 11:26:38 UTC

gnome-mahjongg fails to build if libadwaita not built with vala support:

FAILED: src/gnome-mahjongg.p/game.c src/gnome-mahjongg.p/game-view.c src/gnome-mahjongg.p/gnome-mahjongg.c src/gnome-mahjongg.p/history.c src/gnome-mahjongg.p/map.c src/gnome-mahjongg.p/score-dialog.c src/gnome-mahjongg.p/window.c src/gnome-mahjongg.p/preferences.c 
/usr/bin/valac-0.56 -C --pkg librsvg-2.0 --pkg libadwaita-1 --pkg gtk4 --target-glib ' 2.40.0' --pkg glib-2.0 --color=always --directory src/gnome-mahjongg.p --basedir ../gnome-mahjongg-3.40.0/src --gresources=../gnome-mahjongg-3.40.0/data/org.gnome.Mahjongg.gresource.xml --pkg=posix ../gnome-mahjongg-3.40.0/src/config.vapi ../gnome-mahjongg-3.40.0/src/game.vala ../gnome-mahjongg-3.40.0/src/game-view.vala ../gnome-mahjongg-3.40.0/src/gnome-mahjongg.vala ../gnome-mahjongg-3.40.0/src/history.vala ../gnome-mahjongg-3.40.0/src/map.vala ../gnome-mahjongg-3.40.0/src/score-dialog.vala ../gnome-mahjongg-3.40.0/src/window.vala ../gnome-mahjongg-3.40.0/src/preferences.vala
error: Package `libadwaita-1' not found in specified Vala API directories or GObject-Introspection GIR directories
Compilation failed: 1 error(s), 0 warning(s)


Reproducible: Always

Steps to Reproduce:
1. emerge =games-board/gnome-mahjongg-3.40.0
2.
3.
Actual Results:  
Emerge fails

Expected Results:  
Emerge builds

Modify the ebuild to include [vala] lin libadwaita dependency line

Comment 1 Peter Fox 2023-07-10 11:33:46 UTC

Created attachment 865330 [details]
emerge info

Comment 2 Peter Fox 2023-07-10 11:34:23 UTC

Created attachment 865331 [details]
build log

Comment 3 Peter Fox 2023-07-10 11:39:09 UTC

Created attachment 865332 [details, diff]
Proposed patch

Add vala requirement for libadwaita