Bug 909504 – [guru] dev-libs/boringssl-fips-20230428 adds -Werror flag on its own

• Product: GURU
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-07-02 06:58:41 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/boringssl-fips-20230428 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

[Comment 1 Agostino Sarubbo 2023-07-02 06:58:44 UTC]

Created attachment 864992 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

[Comment 2 Larry the Git Cow 2023-07-02 13:06:48 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=1ee35fbdf88a3e5e0f67e95502574bc11e4c61d8

commit 1ee35fbdf88a3e5e0f67e95502574bc11e4c61d8
Author:     Lucio Sauer <[e-mail]>
AuthorDate: 2023-07-02 11:36:44 +0000
Commit:     Lucio Sauer <[e-mail]>
CommitDate: 2023-07-02 12:11:36 +0000

    dev-libs/boringssl-fips: treeclean
    
    * BoringSSL is not fit to be installed system-wide:
    https://github.com/gentoo/guru/commit/a45331733cf318e1e81901bc64a64540afe2ad59#commitcomment-120138949
    * Gentoo dev acknowledged this change on IRC:
    [12:31]    colores: I'd like to fix the VisibleVcsPkg in dev-libs/* but I'm unsure about how to proceed
                        with dev-libs/boringssl-fips. The authors explicitly discourage you from installing
                        it system-wide (see
    https://github.com/gentoo/guru/commit/a45331733cf318e1e81901bc64a64540afe2ad59#commitcomment-120138949).
                        Do I remove this package and it's revdeps?
    [12:58] +     sam_: yes, it shouldn't even be packaged, really
    [12:58] +     sam_: doe something depend on it, colores?
    
    Closes: https://bugs.gentoo.org/909504
    Closes: https://bugs.gentoo.org/909505
    Signed-off-by: Lucio Sauer <[e-mail]>

 .../boringssl-fips/boringssl-fips-20230428.ebuild  | 40 ----------------
 .../files/boringssl-fips-remove-Werror.patch       | 39 ---------------
 .../fix-boringssl-fips-collisions-openssl.patch    | 55 ----------------------
 dev-libs/boringssl-fips/metadata.xml               | 11 -----
 4 files changed, 145 deletions(-)